Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - CRD v1 docs #16027

Closed
wants to merge 1 commit into from
Closed

WIP - CRD v1 docs #16027

wants to merge 1 commit into from

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Aug 23, 2019

Placeholder PR for CRD v1 API . This API is being promoted from v1beta1 to v1 in 1.16.

Key changes:

  • CRD v1: promote to v1
  • CRD v1: require validation schemas
  • CRD v1: structural schema: require structural schema
  • CRD v1: prevent invalid type attributes in schema
  • CRD v1: only allow default attributes in schema via v1
  • ConversionReview: promote types to v1
  • ConversionReview: allow dispatcher to speak v1
  • ConversionReview: in v1, verify response.uid, kind, apiVersion are set in responses

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c6cf176

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d5f71854126500008a28738

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zhangxiaoyu-zidif
You can assign the PR to them by writing /assign @zhangxiaoyu-zidif in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 23, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 23, 2019

@liggitt If you already opened a placeholder for CRD v1 docs let me know and I'll close this as a dup. Just wanted to get the placeholder up before the deadline.

@liggitt
Copy link
Member

liggitt commented Aug 23, 2019

#15982 was already open by sttts

@sttts
Copy link
Contributor

sttts commented Sep 3, 2019

Have done #15982. Please open PRs against that.

@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants