Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to locate Korean docs #16277

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Fix links to locate Korean docs #16277

merged 2 commits into from
Sep 17, 2019

Conversation

geunho
Copy link
Contributor

@geunho geunho commented Sep 10, 2019

한글 문서 내 몇몇 링크의 페이지가 이미 한글 번역이 완료 되었음에도 영문 페이지를 가리키는 것을 발견했습니다.
이에 작은 pr을 드립니다 😃

@k8s-ci-robot
Copy link
Contributor

Welcome @geunho!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2019
@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit acf1f5a

https://deploy-preview-16277--kubernetes-io-master-staging.netlify.com

@geunho
Copy link
Contributor Author

geunho commented Sep 10, 2019

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 10, 2019
@gochist
Copy link
Member

gochist commented Sep 10, 2019

1.15 문서에도 백포트할 수 있도록 추가 PR(#16289)을 열었습니다.
/lgtm
/assign @claudiajkang

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@seokho-son
Copy link
Member

@geunho 중요한 버그를 잡아주셨네요! 컨트리뷰션 감사합니다. 👍
@gochist 리뷰 감사합니다 ~~
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 48d73a6 into kubernetes:master Sep 17, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 18, 2019
* Fix links to locate Korean docs

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants