Reference Documentation for Kubernetes Components and Tools for 1.17 #18010
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 25e8bc8 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5deed5baeac931000a637a8b |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 92dbf83 https://deploy-preview-18010--kubernetes-io-master-staging.netlify.com |
daminisatya
changed the title
| @@ -913,7 +913,7 @@ kube-apiserver [flags] | |||
| <td colspan="2">--shutdown-delay-duration duration</td> | |||
| </tr> | |||
| <tr> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;">Time to delay the termination. During that time the server keeps serving requests normally and /healthz returns success, but /ready immediately returns failure. Graceful termination starts after this delay has elapsed. This can be used to allow load balancer to stop sending traffic to this server.</td> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;">Time to delay the termination. During that time the server keeps serving requests normally and /healthz returns success, but /readzy immediately returns failure. Graceful termination starts after this delay has elapsed. This can be used to allow load balancer to stop sending traffic to this server.</td> | |||
There was a problem hiding this comment.
readzy looks like a typo; does that need fixing upstream?
There was a problem hiding this comment.
Turns out that, actually, @sftim already did.
@daminisatya did you have revision kubernetes/kubernetes@70132b0 checked out when you generated the reference documentation?
There was a problem hiding this comment.
If I clone kubernetes/kubernetes and check out release-1.17 then run:
git annotate ./staging/src/k8s.io/apiserver/pkg/server/options/server_run_options.go | grep "returns success, but /r.*"I see the fixed wording with /readyz.
Puzzled.
There was a problem hiding this comment.
And ... it was fixed by you, @sftim :)
|
|
||
| <tr> | ||
| <td colspan="2">--cache-dir string Default: "~/.kube/http-cache"</td> | ||
| <td colspan="2">--cache-dir string Default: "/Users/dsatya/.kube/http-cache"</td> |
There was a problem hiding this comment.
better to have something like /home/username/.kube... :)
There was a problem hiding this comment.
Any idea how this username was inserted into the output? Perhaps check the proposed output against the current (v1.16) page.
There was a problem hiding this comment.
@neolit123 Can I apply this manually?
|
i think for kubeadm we had more changes to the reference documentation, but i can't remember what else.. hm EDIT: shouldn't there be a diff for the kubeadm /generated folder? or perhaps this is a separate PR. |
|
Page previews: /* This needs to be manually generated(diff'ed from cmd), if there are changes for the 1.17 release */ |
|
@kbhawkey Can you help on how I can manually generate this page? |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
|
||
| <tr> | ||
| <td colspan="2">--cache-dir string Default: "~/.kube/http-cache"</td> | ||
| <td colspan="2">--cache-dir string Default: "/Users/username/.kube/http-cache"</td> |
There was a problem hiding this comment.
| <td colspan="2">--cache-dir string Default: "/Users/username/.kube/http-cache"</td> | |
| <td colspan="2">--cache-dir string Default: "~/.kube/http-cache"</td> |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.