Fixing broken http://kubernetes.io/kubernetes/third_party/swagger-ui/ #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
nikhiljindal
force-pushed
the
swaggerUIRedirect1.5
branch
from
709940c
to
0fe3d1f
Compare
|
Shoot, I didn't know this was used directly. Should we revert that instead? |
thockin
reviewed
Dec 12, 2016
| --- | ||
|
|
||
| Kubernetes swagger UI has now been replaced by our generated API reference docs | ||
| which can be accessed at http://kubernetes.io/docs/api-reference/README/. |
There was a problem hiding this comment.
Why does this page only have 4 APIs, when we have dozens?
There was a problem hiding this comment.
Sent #1928 to add missing ones
|
Emergency merge to stop the badness |
|
Did this actually fix it?
…On Sun, Dec 11, 2016 at 4:32 PM, Tim Hockin ***@***.***> wrote:
Merged #1921
<#1921>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1921 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVLNRuwQeO1TYEPIgsLrp4hsPTNIhks5rHJYWgaJpZM4LJ8DI>
.
|
|
This PR is for 1.5 branch. I can send the same for master branch but I think the plan is to start serving k8s.io from release-1.5 branch this morning. Problem should be fixed when that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://kubernetes.io/kubernetes/third_party/swagger-ui/ broke when we removed the gh-pages branch (kubernetes/kubernetes#38309 (comment)).
Adding an index.md file at http://kubernetes.io/kubernetes/third_party/swagger-ui/ to inform users that they should now be using the API reference docs.
http://kubernetes.io/kubernetes/third_party/swagger-ui/ is still one of the top results when searching for "kubernetes swagger" so we cannot abandon it.
cc @thockin who removed the gh-pages branch.
Also cc @devin-donnelly @jaredbhatti
This change is