Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization for subscribe button #21296

Merged
merged 1 commit into from May 30, 2020
Merged

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented May 29, 2020

issue #21294
en PR

/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2020
@netlify
Copy link

netlify bot commented May 29, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bacdedb

https://deploy-preview-21296--kubernetes-io-master-staging.netlify.app

@Arhell
Copy link
Member Author

Arhell commented May 29, 2020

review page
https://deploy-preview-21296--kubernetes-io-master-staging.netlify.app/ko/#kubeweekly

@pjhwa
Copy link
Contributor

pjhwa commented May 30, 2020

/assign @gochist

@gochist
Copy link
Member

gochist commented May 30, 2020

As a native Korean speaker, LGTM

/lgtm
/unassign
/assign @onlydole

@k8s-ci-robot k8s-ci-robot assigned onlydole and unassigned gochist May 30, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2020
@onlydole
Copy link
Member

Thank you @Arhell and @gochist!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onlydole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6b33297 into kubernetes:master May 30, 2020
@Arhell Arhell deleted the btn-translate branch May 30, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants