Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix front matter for content/zh/docs/reference/command-line-tools-reference/kube-controller-manager.md #22734

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Fix front matter for content/zh/docs/reference/command-line-tools-reference/kube-controller-manager.md #22734

merged 1 commit into from
Jul 25, 2020

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jul 25, 2020

Adjust front matter to use approach from #21359

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 25, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2020
@netlify
Copy link

netlify bot commented Jul 25, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d817393

https://deploy-preview-22734--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

nit: This en version of this file is auto-generated. Will this file get updated for every release?

@sftim
Copy link
Contributor Author

sftim commented Jul 25, 2020

It would be better to contribute the localization upstream, if feasible (maybe there is already an issue for that work?)

@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit cde38a9 into kubernetes:master Jul 25, 2020
@sftim sftim deleted the 20200725_fix_front_matter_content_type branch June 9, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idealhack idealhack Awaiting requested review from idealhack

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sftim @kbhawkey @tengqm @k8s-ci-robot