Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Rework Deployment concept #22910

Merged
merged 1 commit into from Sep 8, 2020
Merged

[zh] Rework Deployment concept #22910

merged 1 commit into from Sep 8, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Aug 2, 2020

*** WARNING ***
This is a huge page. It takes some time to review.
There are quite some translations that prove the original author didn't understand what the doc is talking about.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 2, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 2, 2020
@netlify
Copy link

netlify bot commented Aug 2, 2020 •
edited

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 62399b8

https://deploy-preview-22910--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Aug 3, 2020

/language ar

@k8s-ci-robot k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Aug 3, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Aug 3, 2020

/remove-language ar

@k8s-ci-robot k8s-ci-robot removed the language/ar Issues or PRs related to Arabic language label Aug 3, 2020
@sftim
Copy link
Contributor

sftim commented Aug 3, 2020

Oops, wrong PR.

markthink
markthink reviewed Aug 9, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2020
chenrui333
chenrui333 reviewed Aug 9, 2020
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite some translations that prove the original author didn't understand what the doc is talking about.

I like that, I will read through later.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 15, 2020
markthink
markthink reviewed Aug 16, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
tanjunchen
tanjunchen reviewed Sep 7, 2020
View reviewed changes
content/zh/docs/concepts/workloads/controllers/deployment.md Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
@tanjunchen
Copy link
Member

/lgtm
/cc @xichengliudui
for approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@xichengliudui
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3a4b604 into kubernetes:master Sep 8, 2020
@tengqm tengqm deleted the zh-rework-deployment branch September 8, 2020 03:35
@shonge shonge mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@markthink markthink markthink left review comments

@tanjunchen tanjunchen tanjunchen left review comments

@idealhack idealhack Awaiting requested review from idealhack

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@markthink markthink

@tanjunchen tanjunchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tengqm @sftim @tanjunchen @xichengliudui @k8s-ci-robot @chenrui333 @markthink