Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new optional support for ConfigMap and Secret #2334

Merged
merged 2 commits into from Jan 24, 2017

Conversation

fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Jan 24, 2017

Corresponds to proposal kubernetes/community#175


This change is Reviewable

@chenopis
Copy link
Contributor

@fraenkel One nitpick: on line 320, can you change that sentence to "When this pod is run, the output will be:" because when you say "will include the lines:" I'm expecting there to be some sort of output. Also, it will match better with the other lines later on where you say that.

@fraenkel
Copy link
Contributor Author

fraenkel commented Jan 24, 2017

@chenopis No problem. I was struggling with some of the wording.
I changed it to just say the output will be empty. Looking at empty output is confusing, did the author forget to write something?

@chenopis
Copy link
Contributor

@fraenkel Yeah, exactly. Thx!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2017
@chenopis chenopis merged commit 324451c into kubernetes:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants