Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: promote the "kubeadm certs" command to GA #24410

Merged
merged 1 commit into from
Nov 12, 2020
Merged

kubeadm: promote the "kubeadm certs" command to GA #24410

merged 1 commit into from
Nov 12, 2020

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Oct 7, 2020 •
edited
Loading

The command resided under "kubeadm alpha certs".
It will be promoted to GA in 1.20 as "kubeadm certs".

The existing command "kubeadm alpha certs" will
remain present for one more release, but it will be hidden
from documentation as it is deprecated.

xref kubernetes/kubeadm#2291

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 7, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 780050d

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f8de3b0b89e1800074bc6ee

@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/cc @yagonobre

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 7, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 7, 2020
@neolit123
Copy link
Member Author

neolit123 commented Oct 7, 2020 •
edited
Loading

note: the generated/* file changes are needed so that this PR can pass CI, but otherwise the docs release process should generate them for 1.20.

neolit123
neolit123 commented Oct 7, 2020
View reviewed changes
content/en/docs/reference/setup-tools/kubeadm/kubeadm-alpha.md
@@ -1,7 +1,4 @@
---
reviewers:
- luxas
- jbeda
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned these emeritus members from the "reviewers" block.

neolit123
neolit123 commented Oct 7, 2020
View reviewed changes
content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md
Please note that the certificate-key gives access to cluster sensitive data, keep it secret!
As a safeguard, uploaded-certs will be deleted in two hours; If necessary, you can use kubeadm init phase upload-certs to reload certs afterward.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace cleanup. hoping that this doesn't break anything.

@neolit123 neolit123 mentioned this pull request Oct 7, 2020
Closed
4 tasks
@sftim
Copy link
Contributor

sftim commented Oct 7, 2020

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 7, 2020
@neolit123
Copy link
Member Author

added missing section for certs generate-csr.

@neolit123 neolit123 mentioned this pull request Oct 13, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2020
@irvifa
Copy link
Member

irvifa commented Oct 17, 2020

Hi @neolit123 I think we need to rebase this PR

@neolit123
kubeadm: promote the "kubeadm certs" command to GA
780050d 
The command resided under "kubeadm alpha certs".
It will be promoted to GA in 1.20 as "kubeadm certs".

The existing command "kubeadm alpha" will
remain present for one more release, but it will be hidden
from documentation as it is deprecated.
@neolit123
Copy link
Member Author

neolit123 commented Oct 19, 2020 •
edited
Loading

rebased on top of #24557
(which made the conflicting changes)

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2020
@neolit123
Copy link
Member Author

neolit123 commented Oct 20, 2020 •
edited
Loading

/cc @tengqm
hi, this PR renames the generated files for kubeadm_alpha_certs_* -> kubeadm_certs_*, with the assumption that since the "kubeadm alpha certs" command will be deprecated in 1.20 it will be hidden from the generator. LMK if this is PR is valid, as is.

@tengqm
Copy link
Contributor

tengqm commented Oct 21, 2020

I'd like to suggest we put this on hold until we are near the release week. There could be further changes to kubeadm tool. Such changes will lead to the changes in the generated docs as well.

@neolit123
Copy link
Member Author

SGTM @tengqm . we have no more planned changes for commands, but merging this late seems fine as long as the docs approvers agree.

@neolit123
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

hey @neolit123 wondering if this is part of an enhancement? could you link the enhancement link here?

@neolit123
Copy link
Member Author

hi, @annajung no it does not have a tracking issue in k/enhancements. historically this has not been done for kubeadm command promotions.

@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

I see, thanks for the clarification! :D

@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign

@annajung
Copy link
Contributor

@kubernetes/sig-cluster-lifecycle can someone else from sig cluster lifecycle provide a tech review / lgtm?

@tengqm
Copy link
Contributor

tengqm commented Nov 11, 2020

@annajung This one doesn't need a tech lgtm. The author is from that sig.

@irvifa
Copy link
Member

irvifa commented Nov 12, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 12, 2020
irvifa
irvifa reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020
irvifa
irvifa reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
irvifa
irvifa reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f82c8ac4f2b9c51488551d034cf1d6f251d3d927

@k8s-ci-robot k8s-ci-robot merged commit d0c6d30 into kubernetes:dev-1.20 Nov 12, 2020
@kbhawkey kbhawkey mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@yagonobre yagonobre Awaiting requested review from yagonobre

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@irvifa irvifa

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@neolit123 @k8sio-netlify-preview-bot @sftim @irvifa @tengqm @annajung @k8s-ci-robot