Update API Priority and Fairness doc for graduation to beta #24975

MikeSpreitzer · 2020-11-10T17:15:23Z

Update the doc page to mention the v1beta1 API group in addition to, and in preference to, the v1alpha. Update the example to use the v1beta1 API group.

k8sio-netlify-preview-bot · 2020-11-10T17:15:28Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 78869f6

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5faecc43c710b6000845b6df

MikeSpreitzer · 2020-11-10T17:16:15Z

@lavalamp
@deads2k
@yue9944882
@adtac
@tkashem
@ahg-g
@MikeSpreitzer

reylejano · 2020-11-10T18:22:09Z

/milestone 1.20
/assign @reylejano-rxm
/sig api-machinery
/hold for ~~k/k PR 90541 and k/k PR 91389~~ k/k PR 96213
/cc @annajung

MikeSpreitzer · 2020-11-10T18:23:52Z

@reylejano-rxm : This is not dependent on k/k PRs 90541 and 91389

reylejano · 2020-11-10T18:29:29Z

@reylejano-rxm : This is not dependent on k/k PRs 90541 and 91389

@MikeSpreitzer I updated the related k/k PR dependency

sftim · 2020-11-11T13:27:32Z

content/en/docs/concepts/cluster-administration/flow-control.md

--feature-gates=APIPriorityAndFairness=true \
--runtime-config=flowcontrol.apiserver.k8s.io/v1alpha1=true \
+--feature-gates=APIPriorityAndFairness=false \
+--runtime-config=flowcontrol.apiserver.k8s.io/v1alpha1=false \


This alpha API group is enabled by default? Is that right?

good catch, no, that should read --runtime-config=flowcontrol.apiserver.k8s.io/v1beta1=false if I'm not mistaken (alpha runtime config flag is false by default)

adtac

/lgtm

except for one minor nit

adtac · 2020-11-11T13:26:23Z

content/en/docs/concepts/cluster-administration/flow-control.md

@@ -7,6 +7,7 @@ min-kubernetes-server-version: v1.18
 <!-- overview -->

 {{< feature-state state="alpha"  for_k8s_version="v1.18" >}}


is it common practice to leave the alpha section in? I couldn't find anything similar from a brief search

I'd imagine the older versions of the docs will have the alpha tag

Yep, remove this line.

adtac · 2020-11-11T13:32:53Z

/lgtm cancel

reylejano · 2020-11-11T19:00:42Z

@MikeSpreitzer , since this feature is graduating to beta, does it need to be updated in the Feature Gates list

MikeSpreitzer · 2020-11-11T19:11:09Z

Ah, yes, the FeatureGates list needs to be updated too.

adtac · 2020-11-11T19:37:02Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -52,6 +52,7 @@ different Kubernetes components.
 | `APIListChunking` | `false` | Alpha | 1.8 | 1.8 |
 | `APIListChunking` | `true` | Beta | 1.9 | |
 | `APIPriorityAndFairness` | `false` | Alpha | 1.17 | |


the convention seems to be to have the last alpha version in the Until column - do we do this only if the alpha API is entirely removed?

Added the "until" for alpha.

annajung · 2020-11-12T22:25:24Z

looks like correct k/k pr for this is kubernetes/kubernetes#96527

MikeSpreitzer · 2020-11-12T22:45:39Z

Oh yes, we had to switch to a different k/k PR because the original author is sleeping now.

sftim

/lgtm
Markdown makes sense, technical changes here are minor.

content/en/docs/concepts/cluster-administration/flow-control.md

annajung · 2020-11-13T14:08:44Z

Note:

/hold
Exception filed (pending approval)

MikeSpreitzer · 2020-11-13T14:09:33Z

@sftim : I took your suggestion, and naturally lost your LGTM for my trouble.
The PR for which we are holding has still not landed yet but it is very close and we have filed for an exception. I expect it to merge today or tomorrow.

sftim · 2020-11-13T14:13:26Z

/lgtm
Markdown makes sense, technical changes here are minor.

Only minor changes since #24975 (review)

BTW - this repo does preserve LGTM through squashes

k8s-ci-robot · 2020-11-13T14:13:42Z

LGTM label has been added.

Git tree hash: 5b36f976ac2f1720cff959599e5f1bd9ba744c9e

MikeSpreitzer · 2020-11-13T18:09:43Z

The force-push to 285bc5c is a squash.

MikeSpreitzer · 2020-11-13T18:12:09Z

aand the force-push to 78869f6 added the overlooked close quote.

sftim · 2020-11-13T18:23:19Z

Preview

/lgtm
😄

k8s-ci-robot · 2020-11-13T18:23:32Z

LGTM label has been added.

Git tree hash: 20d4b15e2a56e2a735bf5ef53fd28e192a222783

kbhawkey · 2020-11-13T18:53:39Z

content/en/docs/concepts/cluster-administration/flow-control.md

+disable them.  The name of the feature gate for APF is
+"APIPriorityAndFairness".  This feature also involves an {{<
+glossary_tooltip term_id="api-group" text="API Group" >}} with: (a) a
+`v1alpha1` version, disabled by default, and (b) a `v1beta1`


The changes seem straightforward.
You could use a list here instead of using:
(a) some text
(b) some more text

This feature includes an {{< glossary_tooltip term_id="api-group" text="API Group" >}} with:

a v1alpha1 version, disabled, and

a v1beta1 version, enabled by default

You can disable the feature gate ...

kbhawkey · 2020-11-13T19:09:08Z

content/en/docs/concepts/cluster-administration/flow-control.md

@@ -189,12 +194,14 @@ that originate from outside your cluster.

 ## Resources
 The flow control API involves two kinds of resources.
-[PriorityLevelConfigurations](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#prioritylevelconfiguration-v1alpha1-flowcontrol-apiserver-k8s-io)
+[PriorityLevelConfigurations](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#prioritylevelconfiguration-v1beta1-flowcontrol-apiserver-k8s-io)


nit: This could be a list?

The flow control API involves two types of resources:

PriorityLevelConfigurations .... define the available isolation classes and the share of the available concurrency
budget that each can handle, and allow for fine-tuning queuing behavior.

FlowSchemas ...

irvifa · 2020-11-13T19:10:19Z

/label tide/method-merge-squash

k8s-ci-robot · 2020-11-13T19:10:20Z

@irvifa: The label(s) /label tide/method-merge-squash cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label tide/method-merge-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

irvifa · 2020-11-13T19:12:00Z

/label tide/merge-method-squash

kbhawkey · 2020-11-13T19:12:29Z

/approve

k8s-ci-robot · 2020-11-13T19:12:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

irvifa · 2020-11-14T09:54:40Z

/hold cancel

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2020

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2020

k8s-ci-robot requested a review from celestehorgan November 10, 2020 17:15

k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 10, 2020

k8s-ci-robot requested a review from tengqm November 10, 2020 17:15

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 10, 2020

MikeSpreitzer mentioned this pull request Nov 10, 2020

Priority and Fairness for API Server Requests kubernetes/enhancements#1040

Closed

4 tasks

k8s-ci-robot assigned reylejano Nov 10, 2020

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 10, 2020

k8s-ci-robot added this to the 1.20 milestone Nov 10, 2020

k8s-ci-robot requested a review from annajung November 10, 2020 18:22

MikeSpreitzer changed the title ~~Update API Priority and Fairness doc for graduatino to beta~~ Update API Priority and Fairness doc for graduation to beta Nov 10, 2020

sftim reviewed Nov 11, 2020

View reviewed changes

adtac reviewed Nov 11, 2020

View reviewed changes

k8s-ci-robot assigned adtac Nov 11, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020

adtac mentioned this pull request Nov 11, 2020

API priority and fairness: beta graduation checklist kubernetes/kubernetes#96119

Closed

12 tasks

MikeSpreitzer force-pushed the apf-to-beta branch from 038398d to 354695a Compare November 11, 2020 19:16

adtac reviewed Nov 11, 2020

View reviewed changes

MikeSpreitzer force-pushed the apf-to-beta branch from 354695a to cf4829a Compare November 11, 2020 19:56

sftim reviewed Nov 13, 2020

View reviewed changes

content/en/docs/concepts/cluster-administration/flow-control.md Outdated Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020

MikeSpreitzer force-pushed the apf-to-beta branch from 2820957 to 285bc5c Compare November 13, 2020 18:09

Update API Priority and Fairness doc for graduatino to beta

78869f6

MikeSpreitzer force-pushed the apf-to-beta branch from 285bc5c to 78869f6 Compare November 13, 2020 18:11

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020

kbhawkey reviewed Nov 13, 2020

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 13, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2020

k8s-ci-robot merged commit bf23ba2 into kubernetes:dev-1.20 Nov 14, 2020

		@@ -7,6 +7,7 @@ min-kubernetes-server-version: v1.18
		<!-- overview -->

		{{< feature-state state="alpha" for_k8s_version="v1.18" >}}

Update API Priority and Fairness doc for graduation to beta #24975

Update API Priority and Fairness doc for graduation to beta #24975

Conversation

MikeSpreitzer commented Nov 10, 2020

k8sio-netlify-preview-bot commented Nov 10, 2020 • edited

MikeSpreitzer commented Nov 10, 2020

reylejano commented Nov 10, 2020 • edited

MikeSpreitzer commented Nov 10, 2020 • edited

reylejano commented Nov 10, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adtac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adtac commented Nov 11, 2020

reylejano commented Nov 11, 2020

MikeSpreitzer commented Nov 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annajung commented Nov 12, 2020

MikeSpreitzer commented Nov 12, 2020

sftim left a comment

Choose a reason for hiding this comment

annajung commented Nov 13, 2020 • edited

MikeSpreitzer commented Nov 13, 2020

sftim commented Nov 13, 2020

k8s-ci-robot commented Nov 13, 2020

MikeSpreitzer commented Nov 13, 2020

MikeSpreitzer commented Nov 13, 2020

sftim commented Nov 13, 2020

k8s-ci-robot commented Nov 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irvifa commented Nov 13, 2020

k8s-ci-robot commented Nov 13, 2020

irvifa commented Nov 13, 2020

kbhawkey commented Nov 13, 2020

k8s-ci-robot commented Nov 13, 2020

irvifa commented Nov 14, 2020

k8sio-netlify-preview-bot commented Nov 10, 2020 •

edited

reylejano commented Nov 10, 2020 •

edited

MikeSpreitzer commented Nov 10, 2020 •

edited

reylejano commented Nov 10, 2020 •

edited

annajung commented Nov 13, 2020 •

edited