Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into dev-1.20 to keep in sync 12-03-20 #25378

Merged
merged 142 commits into from Dec 3, 2020

Conversation

kcmartin
Copy link
Contributor

@kcmartin kcmartin commented Dec 3, 2020

Merge master into dev-1.20 to keep in sync 12-03-20

devries and others added 30 commits August 13, 2020 08:59
- (try to) imply that pod templates are part of an owning resource,
  not part of the pod itself
- explain that the owning resource must replace Pods if the pod
  template changes
Co-authored-by: Karen Bradshaw <kbhawkey@gmail.com>
implementing review comments
implemented review comments
AWS ALB Ingress Controller is now renamed to AWS Load Balancer Controller
implemented feedback
updated review comments
Coil is a new open-source CNI plugin for Kubernetes.

Resources:
- https://github.com/cybozu-go/coil
- https://blog.kintone.io/entry/coilv2
In content/{en, ja, ko, zh}/docs/setup/production-environment/windows/user-guide-windows-containers.md:

    https://gist.github.com/{wagnerandrade => 19WAS85}/5424431
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Switch New York Times case study to use youtube shortcode
AWS ALB Ingress Controller renamed to AWS Load Balancer Controller
…emplate_updates

Improve explanation about pod template updates
commands to create job and cronjob
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2020
@annajung
Copy link
Contributor

annajung commented Dec 3, 2020

commits with build errors:

ad8b32f 72fb7e4 e0a2a5f

Nothing stands out from the logs, similar to the errors we have seen in the past.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7028565e8b150bf0590fd134ca50cb4668f4f727

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 3, 2020

I see this error, perhaps it was fixed in a follow-up PR:

$ git submodule update --init --recursive --depth 1 && make deploy-preview
10:35:31 PM: hugo --enableGitInfo --buildFuture -b https://deploy-preview-25244--kubernetes-io-master-staging.netlify.app
10:37:02 PM: Building sites … ERROR 2020/11/27 03:35:58 [zh] "docs/reference/glossary/controller.md": "kube-cluster" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
ERROR 2020/11/27 03:36:02 [zh] "docs/reference/glossary/dynamic-volume-provisioning.md": "储存类别(storage-class)" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
Total in 90564 ms

@annajung
Copy link
Contributor

annajung commented Dec 3, 2020

Thanks for double-checking @kbhawkey !
Do you know what the process is when there is a build failure like this?

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 3, 2020

I am guessing this error was fixed in a later PR? The site builds.

@annajung
Copy link
Contributor

annajung commented Dec 3, 2020

ahh okay, so I think this happened because merge had multiple commits (https://github.com/kubernetes/website/pull/25244/commits)

So it was fixed by the last change

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 3, 2020

/lgtm

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 3, 2020

Thanks @kcmartin !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 251092f into kubernetes:dev-1.20 Dec 3, 2020
@kcmartin kcmartin deleted the merged-master-dev-1.20 branch December 3, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet