Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about alpha provisioning. #2557

Closed
wants to merge 1 commit into from

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Feb 16, 2017

In 1.6 the alpha annotation does not have any meaning. Reflect it in portable
configuration documentation.

I explicitly did not update any example in this repository that still uses alpha provisioning, as it is the best portable solution for now. It should be updated few releases after 1.6 where all clusters will have a default storage class and alpha annotation won't be needed there.


This change is Reviewable

In 1.6 the alpha annotation does not have any meaning. Reflect it in portable
configuration documentation.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2017
@chenopis chenopis added this to the 1.6 milestone Feb 16, 2017
@chenopis chenopis added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 16, 2017
@chenopis
Copy link
Contributor

@jsafrane If this is for 1.6, please change the base branch from kubernetes:master to kubernetes:release-1.6. Thx

@chenopis chenopis changed the base branch from master to release-1.6 February 17, 2017 17:49
@chenopis chenopis changed the base branch from release-1.6 to master February 17, 2017 17:50
@chenopis chenopis changed the base branch from master to release-1.6 February 17, 2017 18:39
@chenopis chenopis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 17, 2017
Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small grammar typo

At some point, the alpha annotation will cease to have meaning, but the unset `storageClass` field on the PVC
will have the desired effect.
In Kubernetes 1.6 the alpha annotation ceases to have meaning, but a default storage class should be
configured there to provisions all PVCs, including those with the alpha annotation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: "provisions" => "provision"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

@mikedanese mikedanese assigned saad-ali and unassigned mikedanese Feb 21, 2017
@jsafrane
Copy link
Member Author

There is currently discussion if we're going to remove alpha dynamic provisioning in 1.6 or not. I am closing it for now and I will open a new one (against the right branch) when the decision is done and we actually need this PR.

@jsafrane jsafrane closed this Feb 23, 2017
@chenopis
Copy link
Contributor

@jsafrane Ok, sounds good. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants