Update RBAC doc #2618
Merged
Update RBAC doc #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
cc @kubernetes/sig-auth-misc |
deads2k
reviewed
Feb 27, 2017
docs/admin/authorization/rbac.md
Outdated
| <td><b>system:nodes</b> group</td> | ||
| <td>Allows access to resources required by the kubelet component, <b>including read access to secrets, and write access to pods</b>. | ||
| In the future, read access to secrets and write access to pods will be restricted to objects scheduled to the node. | ||
| To maintain permissions in the future, Kubelets must identify themselves with a username in the form <b>system:node:<node-name></b>. |
There was a problem hiding this comment.
You keying based on group or only based on name?
There was a problem hiding this comment.
both, probably? will update.
deads2k
reviewed
Feb 27, 2017
docs/admin/authorization/rbac.md
Outdated
| don't already have even when the RBAC authorizer it disabled__. If "user-1" | ||
| does not have the ability to read secrets in "namespace-a", they cannot create | ||
| a binding that would grant that permission to themselves or any other user. | ||
| The RBAC API inherently prevents users from escalating privileges by editing roles or role bindings. |
There was a problem hiding this comment.
Seems like you should describe the permission we use to allow binding an escalating role.
There was a problem hiding this comment.
I do, later. hoist it into the summary?
There was a problem hiding this comment.
I do, later. hoist it into the summary?
Yeah. The summary is no longer accurate.
|
lgtm otherwise |
This was referenced Feb 27, 2017
|
I'm working on addressing the few comments. Will push an update tonight |
|
@liggitt Great, thanks! |
|
@deads2k comments addressed, PTAL |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview at https://deploy-preview-2618--kubernetes-io-master-staging.netlify.com/docs/admin/authorization/rbac/
This change is