Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an invalid location.hash #26400

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix an invalid location.hash #26400

merged 1 commit into from
Feb 5, 2021

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Feb 5, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit df34ae5

https://deploy-preview-26400--kubernetes-io-master-staging.netlify.app

@oke-py
Copy link
Contributor Author

oke-py commented Feb 5, 2021

/assign @irvifa

@celestehorgan
Copy link
Contributor

/lgtm
/approve

Thank you @oke-py

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94b8d1b67a9544a55ebe24d36852f158295b6e73

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 57648a9 into kubernetes:master Feb 5, 2021
@oke-py oke-py deleted the href-ephemeral-container branch February 5, 2021 21:53
This was referenced Feb 9, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verb verb Awaiting requested review from verb

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@irvifa irvifa

@celestehorgan celestehorgan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oke-py @celestehorgan @k8s-ci-robot @irvifa