Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage capacity: beta #26800

Merged
merged 1 commit into from
Mar 12, 2021
Merged

storage capacity: beta #26800

merged 1 commit into from
Mar 12, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 2, 2021

After the promotion to beta in 1.21, enabling the feature is easier
and mostly just depends on the CSI driver deployment.

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 2, 2021 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit f5aaf40

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60408bae0ed3e900080427af

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 2, 2021
@pohly
Copy link
Contributor Author

pohly commented Mar 2, 2021

/hold

The actual promotion hasn't happened yet. See kubernetes/kubernetes#99641 for that.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 2, 2021
@pohly pohly mentioned this pull request Mar 2, 2021
Closed
@pohly
Copy link
Contributor Author

pohly commented Mar 2, 2021

cc: @reylejano

@pohly pohly mentioned this pull request Mar 2, 2021
Closed
4 tasks
@reylejano
Copy link
Member

/milestone 1.21
/assign @tengqm
/sig storage
hold until kubernetes/kubernetes#99641 merges

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 2, 2021
@tengqm
Copy link
Contributor

tengqm commented Mar 4, 2021

Please make sure /docs/reference/command-line-tools-reference/feature-gates.md is properly updated when the upstream promotion is done. Thanks.

@pohly
Copy link
Contributor Author

pohly commented Mar 4, 2021

Please make sure /docs/reference/command-line-tools-reference/feature-gates.md is properly updated when the upstream promotion is done.

Thanks for pointing it out. I have added it to #26801

@pohly
storage capacity: beta
f5aaf40 
After the promotion to beta in 1.21, enabling the feature is easier
and mostly just depends on the CSI driver deployment.
@pohly
Copy link
Contributor Author

pohly commented Mar 9, 2021

/hold cancel

All PRs have been merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@tengqm
Copy link
Contributor

tengqm commented Mar 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 014bcbe3f5fe6503e44f724266cbcd6218165003

@k8s-ci-robot k8s-ci-robot merged commit be14fc3 into kubernetes:dev-1.21 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@kbhawkey kbhawkey

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pohly @k8sio-netlify-preview-bot @reylejano @tengqm @k8s-ci-robot @kbhawkey