Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Sysctl to ga #26981

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Promote Sysctl to ga #26981

merged 1 commit into from
Mar 27, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 10, 2021

Wait for e2e promotion to conformance testing

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 10, 2021 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 3d7aaef

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/605d45cb1da3c30007d70084

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 10, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 10, 2021

/cc tengqm

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2021
@pacoxu pacoxu mentioned this pull request Mar 10, 2021
Closed
20 tasks
@tengqm
Copy link
Contributor

tengqm commented Mar 10, 2021

/assign

@tengqm
Copy link
Contributor

tengqm commented Mar 10, 2021

/milestone 1.21

neolit123
neolit123 reviewed Mar 10, 2021
View reviewed changes
content/en/docs/tasks/administer-cluster/sysctl-cluster.md Outdated
@@ -6,7 +6,7 @@ content_type: task
---

<!-- overview -->
{{< feature-state for_k8s_version="v1.12" state="beta" >}}
{{< feature-state for_k8s_version="v1.21" state="GA" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this "feature-state" makes a lot of sense here.
sysctl is not a tool originating from the Kubernetes project and its usage cannot fall under a GA or Beta state.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was added in this PR:
#8804

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I should remove it?

I tried to summarize the history of sysctls in kubernetes/enhancements#34 (comment)

What we have done in 1.21 is lock the feature gate to True and promote e2e test cases(which is in process).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't maintain this page, so i was just commenting.
sig-docs may have feedback on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature gates page lists Sysctls as a feature. Is that incorrect?

@tengqm
Copy link
Contributor

tengqm commented Mar 11, 2021

/hold
Feel free to unhold when E2E conformance test is ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
@reylejano
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 12, 2021
@pacoxu pacoxu changed the title [PlaceHolder] Promote Sysctl to ga Promote Sysctl to ga Mar 18, 2021
@tengqm
Copy link
Contributor

tengqm commented Mar 19, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@reylejano
Copy link
Member

Hi @pacoxu, looks like this PR is waiting for the e2e promotion to conformance testing in kubernetes/kubernetes#99734 to remove the hold.
Just wanted to share upcoming doc related dates for the 1.21 release:

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 25, 2021 •
edited
Loading

@reylejano Thanks for reminding
I will update this pr after that e2e promotion PR merged

@reylejano
Copy link
Member

@pacoxu Can you squash your commits and rebase
Thank you

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2021
@pacoxu @ehashman
promote sysctl to GA: update sysctl feature gate status
3d7aaef 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Mar 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Mar 26, 2021

Squanshed and rebased.

ehashman
ehashman reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef4f80fa02ae5551c4cb1d6a45cc03652ceeeef3

@pacoxu
Copy link
Member Author

pacoxu commented Mar 27, 2021

/hold cancel
the test case promotion was merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit ba7aced into kubernetes:dev-1.21 Mar 27, 2021
@sftim sftim mentioned this pull request Apr 1, 2021
Merged
@pacoxu pacoxu deleted the sysctl-ga branch June 26, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@ehashman ehashman ehashman left review comments

@sftim sftim sftim left review comments

@khenidak khenidak Awaiting requested review from khenidak

@sttts sttts Awaiting requested review from sttts

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@ehashman ehashman

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pacoxu @k8sio-netlify-preview-bot @tengqm @reylejano @k8s-ci-robot @neolit123 @ehashman @sftim