Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pod eviction concept topic #27739

Merged
merged 1 commit into from
May 20, 2021

Conversation

shannonxtreme
Copy link
Contributor

@shannonxtreme shannonxtreme commented Apr 26, 2021

Description

Work for #14507

Created a new draft concept topic for Pod Eviction. Merged content from out-of-resource.md and eviction-policy.md.

Questions/comments

Closed issues

  • [Line 37] - the control plane, the scheduler, or "the control plane or kube-controller manager"?
  • [Line 88-91] - What is the best way to describe nodefs and imagefs? Related comment thread.
  • [Line 96-100] - Has the kubelet deprecated garbage collection for eviction in DiskPressure conditions?
  • [Line 245-251] - should we reword to make it clear that only the pods' cgroup is checked for memory eviction? Related comment
  • Verify that the Known Issues list and any areas marked for "future deprecation" are still valid.
  • https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ has many conceptual sections which I suggest we move to this topic. That task topic doesn't actually have any "tasks". We should consider adding instructions in that topic for actually configuring the parameters, and move the conceptual info to the Eviction Parameters section in this concept topic.
  • Where does this topic belong? Scheduling and Eviction or Cluster Administration? Related discussion thread
  • [Line 199-216] - does "garbage collect" replace "delete" in all four points?

/sig docs
/language en
/do-not-merge work-in-progress
/assign @sftim

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2021
@netlify
Copy link

netlify bot commented Apr 26, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c184f20

https://deploy-preview-27739--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Apr 27, 2021

I agree that https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ doesn't really explain a task. We could actually redirect it to the new page if we don't replace it.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback that I hope is useful

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2021
@shannonxtreme
Copy link
Contributor Author

I ported over content from the Out of Resource Handling topic (and made lots of edits to it). We can remove that topic entirely. Same for "Eviction Policy" - that content is now in Eviction.md.

@shannonxtreme
Copy link
Contributor Author

@sftim I've reached out to #sig-node and I'll re-request a review from you once I have the info I need from them 😄

@ehashman
Copy link
Member

/cc @dashpole @bobbypage

Copy link
Contributor Author

@shannonxtreme shannonxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented some of @dashpole's edits and added followups to others.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021
@sftim
Copy link
Contributor

sftim commented May 17, 2021

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 144a5aeeb93c9a85550516b0cea2307ad524f666

@shannonxtreme
Copy link
Contributor Author

👀

@shannonxtreme
Copy link
Contributor Author

@sftim what else do I need for approval on this one?

@sftim
Copy link
Contributor

sftim commented May 20, 2021

If someone who's not me LGTMs this, I can approve it.

@shannonxtreme
Copy link
Contributor Author

@alculquicondor sorry, I pushed to implement your final comment and it removed your lgtm. Would you mind adding it again? Thanks!

@alculquicondor
Copy link
Member

/lgtm

still applies :)

@sftim
Copy link
Contributor

sftim commented May 20, 2021

Let's do this
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8f8b147 into kubernetes:master May 20, 2021
@shannonxtreme shannonxtreme deleted the pod-eviction branch May 20, 2021 20:39
@shannonxtreme shannonxtreme restored the pod-eviction branch May 20, 2021 20:39
@shannonxtreme shannonxtreme deleted the pod-eviction branch May 20, 2021 20:39
@shannonxtreme shannonxtreme restored the pod-eviction branch May 20, 2021 20:39
@shannonxtreme shannonxtreme deleted the pod-eviction branch May 20, 2021 20:39
shannonxtreme added a commit to shannonxtreme/website that referenced this pull request Nov 11, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
kevindelgado pushed a commit to kevindelgado/kubernetes.github.io that referenced this pull request Nov 17, 2021
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs.

Some highlights:

* kubernetes#26848
* kubernetes#27716
* kubernetes#27739
* kubernetes#28870
* kubernetes#28740
* kubernetes#28617

Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants