Update "multiple schedulers" example #30107

chirangaalwis · 2021-10-16T09:37:30Z

Description:
Update multiple scheduler deployment example to align with changes introduced via v1.22. Addresses #29342.

Test Environment:

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.1", GitCommit:"632ed300f2c34f6d6d15ca4cef3d3c7073412212", GitTreeState:"clean", BuildDate:"2021-08-20T00:45:19Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}

Furthermore, used the default kube-scheduler image k8s.gcr.io/kube-scheduler:v1.22.0 for testing.

Remove invalid scheduler args, add new scheduler args and add new Scheduler Configuration for defining scheduler name

Defaults to 0.0.0.0

netlify · 2021-10-16T09:50:54Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 7449bb3

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61814aa25b0e4200073c8a18

😎 Browse the preview: https://deploy-preview-30107--kubernetes-io-main-staging.netlify.app

sftim

/sig scheduling

content/en/examples/admin/sched/my-scheduler.yaml

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

content/en/examples/admin/sched/my-scheduler.yaml

Co-authored-by: Deepak Gupta <deepakgdkg1g8868@gmail.com>

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

chirangaalwis · 2021-10-18T15:19:10Z

@alculquicondor improved the PR based on the review.

alculquicondor · 2021-10-18T18:12:35Z

/lgtm

k8s-ci-robot · 2021-10-18T18:12:51Z

LGTM label has been added.

Git tree hash: 505491626e9fa6d95dd97a76072082e448014bb1

Huang-Wei · 2021-10-25T18:04:23Z

@sftim This PR looks good in terms of sig-scheduling, would you mind approving this PR?

alculquicondor · 2021-11-01T19:33:52Z

/assign @reylejano

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

Co-authored-by: Rey Lejano <rlejano@gmail.com>

chirangaalwis · 2021-11-02T05:02:35Z

@reylejano please find the suggestions integrated into the PR. Appreciate if this could be reviewed and approved.

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

reylejano · 2021-11-02T06:15:28Z

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

@@ -71,15 +71,24 @@ config. Save it as `my-scheduler.yaml`:

 {{< codenew file="admin/sched/my-scheduler.yaml" >}}

-An important thing to note here is that the name of the scheduler specified as an
-argument to the scheduler command in the container spec should be unique. This is the name that is matched against the value of the optional `spec.schedulerName` on pods, to determine whether this scheduler is responsible for scheduling a particular pod.
+In the above manifest, you use a [Scheduler Configuration](/docs/reference/scheduling/config/)


Is it better to refer to Scheduler Configuration as KubeSchedulerConfiguration?
KubeSchedulerConfiguration configures a scheduler. I'm not sure what is better to use.
If Scheduler Configuration is not an API object then it should be lower case.

@reylejano IMO, it is better to use KubeSchedulerConfiguration as this avoids any confusion regarding the resource type (this is an API resource type although it is not a server resource type).

@alculquicondor @damemi WDYT?

I usually try to use KubeSchedulerConfiguration to show that I am specifically talking about this file/API object (and not, for example, other types of config like flags/policy/etc...)

KubeSchedulerConfiguration sgtm

@damemi @alculquicondor ack. Will update.

@reylejano updated in 7449bb3.

reylejano · 2021-11-02T06:19:35Z

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

@@ -110,11 +119,15 @@ pod in this list.

 To run multiple-scheduler with leader election enabled, you must do the following:

-First, update the following fields in your YAML file:
+First, update the scheduler configuration (earlier you applied a


See my comment about scheduler configuration.
In either case, we should keep the case the same on this page as

Scheduler Configuration

is upper camel case in other parts of the page

@reylejano already updated with c5cb03a.

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md

Co-authored-by: Rey Lejano <rlejano@gmail.com>

chirangaalwis · 2021-11-02T14:29:17Z

@reylejano updated based on review comments. Please review and approve.

reylejano · 2021-11-02T22:26:34Z

Thank you so much for the updates
Reapplying lgtm from alculquicondor in a previous comment
/lgtm

k8s-ci-robot · 2021-11-02T22:26:53Z

LGTM label has been added.

Git tree hash: 19ca6df83b45429e990bf4fc661f693eaa103b69

reylejano · 2021-11-02T22:29:13Z

/approve

k8s-ci-robot · 2021-11-02T22:30:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chirangaalwis added 5 commits October 16, 2021 12:49

Update custom scheduler example for v1.22+

067f8a9

Remove invalid scheduler args, add new scheduler args and add new Scheduler Configuration for defining scheduler name

Remove --bind-address kube-scheduler argument

0add8b4

Defaults to 0.0.0.0

Update multiple scheduler deployment guide

6ec9029

Update multiple scheduler with HA guide

95be4e5

Update references to invalid --scheduler-name arg

8e250cf

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2021

k8s-ci-robot requested review from davidopp and jimangel October 16, 2021 09:38

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 16, 2021

sftim reviewed Oct 16, 2021

View reviewed changes

content/en/examples/admin/sched/my-scheduler.yaml Show resolved Hide resolved

k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 16, 2021

Re-order ConfigMap definition

b06baf8

sftim reviewed Oct 17, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

Add reference to the created scheduler configuration CM

1084647

Co-authored-by: Tim Bannister <tim@scalefactory.com>

deeepsig reviewed Oct 18, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

alculquicondor reviewed Oct 18, 2021

View reviewed changes

chirangaalwis and others added 4 commits October 18, 2021 20:28

Rearrange words for better meaning

9a0f0e2

Co-authored-by: Deepak Gupta <deepakgdkg1g8868@gmail.com>

Remove unnecessary reference to scheduler

dcbf152

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

Remove unnecessary comment

fc25753

Add extra details for clarity

35525d1

k8s-ci-robot assigned alculquicondor Oct 18, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2021

k8s-ci-robot assigned reylejano Nov 1, 2021

reylejano reviewed Nov 1, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

reylejano reviewed Nov 1, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

Add content best practices

eedbfd5

Co-authored-by: Rey Lejano <rlejano@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021

Improve and reorder the wording

514db9e

Co-authored-by: Rey Lejano <rlejano@gmail.com>

reylejano reviewed Nov 2, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

reylejano reviewed Nov 2, 2021

View reviewed changes

content/en/docs/tasks/extend-kubernetes/configure-multiple-schedulers.md Outdated Show resolved Hide resolved

chirangaalwis and others added 3 commits November 2, 2021 13:59

Use note short code to highlight the content

7b6d84e

Co-authored-by: Rey Lejano <rlejano@gmail.com>

Shorten the description on field updating

c5cb03a

Co-authored-by: Rey Lejano <rlejano@gmail.com>

Update config refs to KubeSchedulerConfiguration

7449bb3

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021

k8s-ci-robot merged commit f8276a4 into kubernetes:main Nov 2, 2021

ingvagabund mentioned this pull request Jan 20, 2022

Configure multiple schedulers: switch to the secure ports #31419

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update "multiple schedulers" example #30107

Update "multiple schedulers" example #30107

chirangaalwis commented Oct 16, 2021 •

edited

netlify bot commented Oct 16, 2021 •

edited

sftim left a comment

chirangaalwis commented Oct 18, 2021

alculquicondor commented Oct 18, 2021

k8s-ci-robot commented Oct 18, 2021

Huang-Wei commented Oct 25, 2021

alculquicondor commented Nov 1, 2021

chirangaalwis commented Nov 2, 2021

reylejano Nov 2, 2021 •

edited

chirangaalwis Nov 2, 2021 •

edited

damemi Nov 2, 2021

alculquicondor Nov 2, 2021

chirangaalwis Nov 2, 2021

chirangaalwis Nov 2, 2021

reylejano Nov 2, 2021

chirangaalwis Nov 2, 2021

chirangaalwis commented Nov 2, 2021

reylejano commented Nov 2, 2021 •

edited

k8s-ci-robot commented Nov 2, 2021

reylejano commented Nov 2, 2021

k8s-ci-robot commented Nov 2, 2021

Update "multiple schedulers" example #30107

Update "multiple schedulers" example #30107

Conversation

chirangaalwis commented Oct 16, 2021 • edited

netlify bot commented Oct 16, 2021 • edited

sftim left a comment

Choose a reason for hiding this comment

chirangaalwis commented Oct 18, 2021

alculquicondor commented Oct 18, 2021

k8s-ci-robot commented Oct 18, 2021

Huang-Wei commented Oct 25, 2021

alculquicondor commented Nov 1, 2021

chirangaalwis commented Nov 2, 2021

reylejano Nov 2, 2021 • edited

Choose a reason for hiding this comment

chirangaalwis Nov 2, 2021 • edited

Choose a reason for hiding this comment

damemi Nov 2, 2021

Choose a reason for hiding this comment

alculquicondor Nov 2, 2021

Choose a reason for hiding this comment

chirangaalwis Nov 2, 2021

Choose a reason for hiding this comment

chirangaalwis Nov 2, 2021

Choose a reason for hiding this comment

reylejano Nov 2, 2021

Choose a reason for hiding this comment

chirangaalwis Nov 2, 2021

Choose a reason for hiding this comment

chirangaalwis commented Nov 2, 2021

reylejano commented Nov 2, 2021 • edited

k8s-ci-robot commented Nov 2, 2021

reylejano commented Nov 2, 2021

k8s-ci-robot commented Nov 2, 2021

chirangaalwis commented Oct 16, 2021 •

edited

netlify bot commented Oct 16, 2021 •

edited

reylejano Nov 2, 2021 •

edited

chirangaalwis Nov 2, 2021 •

edited

reylejano commented Nov 2, 2021 •

edited