Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hpa v2beta2 to deprecation guide for v1.23 #30720

Conversation

reylejano
Copy link
Member

This PR adds HorizontalPodAutoscaler autoscaling/v2beta2 API removal for Kubernetes v1.27.
autoscaling/v2beta2 API is deprecated in v1.23 as autoscaling/v2 reaches stable in v1.23

According to the HPA v2 to Stable KEP working document and the Kubernetes Deprecation Policy, autoscaling/v2beta2 must be supported for 9 months or 3 releases (which ever is longer) after the announced deprecation.

autoscaling/v2beta2 must be served in v1.24, v1.25, v1.26 and can be removed in v1.27

/cc @kubernetes/sig-autoscaling-pr-reviews @jlbutler @sftim
/assign @josephburnett @gjtempleton
/hold until lgtm from SIG Autoscaling

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2021
@netlify
Copy link

netlify bot commented Dec 2, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: aba8166

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61ad640a7ffd0800076103c0

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 2, 2021

* Migrate manifests and API clients to use the **autoscaling/v2** API version, available since v1.23.
* All existing persisted objects are accessible via the new API
* No notable changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some field names have been renamed(?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephburnett @gjtempleton , please confirm if there are field names renamed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change ended up not happening due to the extra work that would have been required, see discussion here: https://github.com/kubernetes/kubernetes/pull/102534/files#r662447798

@reylejano reylejano force-pushed the add-hpa-v2beta2-deprecation-guide branch from b9fe827 to 1a3314e Compare December 3, 2021 14:14
@sftim
Copy link
Contributor

sftim commented Dec 3, 2021

/lgtm
/approve

Leaving hold in place

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc66ec050614a9ba6d5f39a6d5c0d4aea6a829bd

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@sftim
Copy link
Contributor

sftim commented Dec 3, 2021

BTW, nothing stops us selecting and announcing a longer deprecation period (AFAIK). The one here is the guaranteed minimum.

@reylejano
Copy link
Member Author

@gjtempleton can you confirm the removal of autoscaling/v2beta2 is targeted for v1.27

@gjtempleton
Copy link
Member

@reylejano I don't think we've explicitly targetted removal for 1.27 in any of the docs around the promotion to GA, we only called out the timeline for the deprecation notices of v2beta1 and v2beta2, not the accompanying removal. As a side note, I realise the page being added to doesn't currently call out when we plan on stopping serving v2beta1 either.

@josephburnett would be best placed to speak to this, but I would be surprised if we didn't aim to remove these APIs as soon as possible under the deprecation policy.

@reylejano
Copy link
Member Author

I'm considering closing this PR if there is no explicit target removal of the autoscaling/v2beta2 API

@sftim , what are your thoughts?

@sftim
Copy link
Contributor

sftim commented Dec 5, 2021

When we deprecate any built-in API we should publish a migration guide, even if we're unable to confirm when the removal is due.

@reylejano
Copy link
Member Author

reylejano commented Dec 6, 2021

Looks like v2beta2 was added on May 21, 2018
Assuming the introduction of v2beta2 deprecated v2beta1. Since it's been more than 3 releases and more than 9 months since v2beta1 was deprecated, v2beta1 can be removed in any future release after 1.23.
I added the removal of v2beta1 to the deprecation guide under 1.24 as 1.24 is the earliest release v2beta1 can no longer be served at this point.

@josephburnett , please make any recommendations on the targeted removals of v2beta1 and v2beta2 and confirm if all existing persisted objects are accessible via autoscaling/v2 and if there are notable changes to add to the deprecation guide

@reylejano reylejano force-pushed the add-hpa-v2beta2-deprecation-guide branch from 1a3314e to aba8166 Compare December 6, 2021 01:14
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@reylejano
Copy link
Member Author

@sftim , @gjtempleton , @josephburnett without a target release to remove v2beta1 and v2beta2, is this PR sufficient to merge to inform users the earliest release v2beta1 and v2beta2 can be removed?

@reylejano
Copy link
Member Author

As we approach freezing k/website for the 1.23 release, I'm changing the target branch to main

@reylejano reylejano changed the base branch from dev-1.23 to main December 6, 2021 21:09
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2021
@reylejano reylejano changed the base branch from main to dev-1.23 December 6, 2021 21:09
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2021
@reylejano
Copy link
Member Author

Closing since k/website is getting ready to be frozen for the 1.23 release tomorrow
Closing in favor of PR #30776 to main
/close

@k8s-ci-robot
Copy link
Contributor

@reylejano: Closed this PR.

In response to this:

Closing since k/website is getting ready to be frozen for the 1.23 release tomorrow
Closing in favor of PR #30776 to main
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants