-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hpa v2beta2 to deprecation guide for v1.23 #30720
Add hpa v2beta2 to deprecation guide for v1.23 #30720
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: aba8166 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61ad640a7ffd0800076103c0 |
|
||
* Migrate manifests and API clients to use the **autoscaling/v2** API version, available since v1.23. | ||
* All existing persisted objects are accessible via the new API | ||
* No notable changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some field names have been renamed(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, https://github.com/kubernetes/enhancements/tree/master/keps/sig-autoscaling/2702-graduate-hpa-api-to-GA#renames is my basis for suspecting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephburnett @gjtempleton , please confirm if there are field names renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this change ended up not happening due to the extra work that would have been required, see discussion here: https://github.com/kubernetes/kubernetes/pull/102534/files#r662447798
b9fe827
to
1a3314e
Compare
/lgtm Leaving hold in place |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: dc66ec050614a9ba6d5f39a6d5c0d4aea6a829bd
|
BTW, nothing stops us selecting and announcing a longer deprecation period (AFAIK). The one here is the guaranteed minimum. |
@gjtempleton can you confirm the removal of |
@reylejano I don't think we've explicitly targetted removal for 1.27 in any of the docs around the promotion to GA, we only called out the timeline for the deprecation notices of v2beta1 and v2beta2, not the accompanying removal. As a side note, I realise the page being added to doesn't currently call out when we plan on stopping serving v2beta1 either. @josephburnett would be best placed to speak to this, but I would be surprised if we didn't aim to remove these APIs as soon as possible under the deprecation policy. |
I'm considering closing this PR if there is no explicit target removal of the @sftim , what are your thoughts? |
When we deprecate any built-in API we should publish a migration guide, even if we're unable to confirm when the removal is due. |
Looks like v2beta2 was added on May 21, 2018 @josephburnett , please make any recommendations on the targeted removals of v2beta1 and v2beta2 and confirm if all existing persisted objects are accessible via |
1a3314e
to
aba8166
Compare
New changes are detected. LGTM label has been removed. |
@sftim , @gjtempleton , @josephburnett without a target release to remove |
As we approach freezing k/website for the 1.23 release, I'm changing the target branch to main |
Closing since k/website is getting ready to be frozen for the 1.23 release tomorrow |
@reylejano: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds HorizontalPodAutoscaler
autoscaling/v2beta2
API removal for Kubernetes v1.27.autoscaling/v2beta2
API is deprecated in v1.23 asautoscaling/v2
reaches stable in v1.23According to the HPA v2 to Stable KEP working document and the Kubernetes Deprecation Policy,
autoscaling/v2beta2
must be supported for 9 months or 3 releases (which ever is longer) after the announced deprecation.autoscaling/v2beta2
must be served in v1.24, v1.25, v1.26 and can be removed in v1.27/cc @kubernetes/sig-autoscaling-pr-reviews @jlbutler @sftim
/assign @josephburnett @gjtempleton
/hold until lgtm from SIG Autoscaling