Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup notes in Define a Command and Arguments docs #31058

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Cleanup notes in Define a Command and Arguments docs #31058

merged 1 commit into from
Jan 5, 2022

Conversation

championshuttler
Copy link
Contributor

Fix #30971

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 21, 2021
@netlify
Copy link

netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 7a2863b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61c39c0060ab1300081fb61f

😎 Browse the preview: https://deploy-preview-31058--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Jan 1, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d185379e959d6b6ee000a148cf02a9fe9481c48

@annajung
Copy link
Contributor

annajung commented Jan 5, 2022

page: https://deploy-preview-31058--kubernetes-io-main-staging.netlify.app/docs/tasks/inject-data-application/define-command-argument-container/

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1b75c44 into kubernetes:main Jan 5, 2022
@mengjiao-liu mengjiao-liu mentioned this pull request Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Docs - Dockershim Removal
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Tasks > Inject Data into Applications > Define a Command and Arguments
6 participants
@championshuttler @k8s-ci-robot @annajung @steren @sftim @libinglong