Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval permission for 1.24 release #31373

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Approval permission for 1.24 release #31373

merged 1 commit into from
Jan 19, 2022

Conversation

nate-double-u
Copy link
Contributor

As the 1.24 Release Docs lead, I would like to add myself to the approver list for the dev-1.24 branch.

/cc @jimangel @divya-mohan0209 @sftim

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 9226880

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61e5ec0168f37100081e8c38

😎 Browse the preview: https://deploy-preview-31373--kubernetes-io-main-staging.netlify.app

@nate-double-u
Copy link
Contributor Author

/cc @JamesLaverack, FYI

@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c848b31ceb2777c4d6c7896e45d14e3c3db65184

@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

/approve

@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

I think this PR targets the wrong branch @nate-double-u

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@nate-double-u
Copy link
Contributor Author

I thought that the system would only pickup permissions from the main branch.
Previous sample PR: #26114

@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

I'm pretty sure that Prow takes its idea of permissions from the target branch. I'm willing to be proved wrong, mind.

@nate-double-u nate-double-u changed the base branch from main to dev-1.24 January 19, 2022 17:20
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 7cc218f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61e84b5ae39a670007ef85ca

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2022
@nate-double-u
Copy link
Contributor Author

Let's try it, I've changed the target branch.

@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

/lgtm
/approve

LGTM also from https://github.com/kubernetes/website/pull/31373/files/92268803a7e00c8b4182e568058acfd047312eda..b8aa75a5600eb460194ee011e9c8738e77eb694f (thanks @kbhawkey)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba4ee7546208abf33d077d3b7c96b9cea41e52f7

sftim
sftim reviewed Jan 19, 2022
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@nate-double-u
Approval permission for 1.24 release
7cc218f 
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2bc573e0341a9522ba9652f3eb1a948d61dc91a0

@k8s-ci-robot k8s-ci-robot merged commit dd1f2f1 into kubernetes:dev-1.24 Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Jan 19, 2022
@nate-double-u nate-double-u deleted the approval-request branch January 19, 2022 17:36
@nate-double-u
Copy link
Contributor Author

Thanks everyone!

@nate-double-u
Copy link
Contributor Author

Come release day, I may need permissions on main as well, but that's something we can look into.

@jlbutler
Copy link
Contributor

Fwiw, previous PRs targeted main for this. But as long as it works, all good.

For reference, this PR is step 2 from 'Ensure access is set up' in the docs timeline.

For release day, you'll need to be temporarily added to the maintainers org. That's this step.

Hope that helps!

@sftim
Copy link
Contributor

sftim commented Jan 19, 2022

The problem with targeting main is that:

  • you get access to main before it's needed
  • you have to merge that change into dev-1.24 (which you can't yet approve!) before it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@kbhawkey kbhawkey

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nate-double-u @kbhawkey @k8s-ci-robot @sftim @jlbutler