New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed kubenet reference from docs #31667
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 7fc8963 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6214e58847e1cc00081e04fb |
/lgtm |
LGTM label has been added. Git tree hash: 6f56d5f23f27117f93a6be918c8b3a4413bf1104
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mk46
I have some inline feedback - I hope it's useful.
Also one piece to suggest a change you haven't made. For the dockershim removal, we should also edit:
The kubelet has a single default network plugin, and a default network common to the entire cluster. It probes for plugins when it starts up, remembers what it finds, and executes the selected plugin at appropriate times in the pod lifecycle (this is only true for Docker, as CRI manages its own CNI plugins). There are two Kubelet command line parameters to keep in mind when using plugins:
to avoid mentioning Docker [Engine].
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md
Outdated
Show resolved
Hide resolved
@tengqm in light of my review, what do you recommend:
? |
@sftim I'd vote for one more revision before kicking this in. |
@mk46 Would you like give this PR another stab? |
Hi @tengqm, I would like to remove the below pages in favor of https://github.com/kubernetes/kubernetes/blob/release-1.23/CHANGELOG/CHANGELOG-1.23.md#ipv4ipv6-dual-stack-networking-graduates-to-ga
Are these changes make sense? |
Maybe you can help file an issue about the problem to address. My understanding of this PR is that it is about removal of kubenet. |
@mk46, we still need the following pages:
I'm not so sure about https://kubernetes.io/docs/concepts/services-networking/dual-stack/ but we should not simply remove it. We might possibly want to reshape it to discuss the three network family options (single stack IPv6, single stack IPv4, dual stack) on an equal footing. Alongside such a change we could add a page about validating single-stack networking, and maybe an overview page about validating that your cluster is healthy. For v1.24 we need a smaller change that merely omits mention of kubenet. The changes you've proposed are about right; my previous feedback still applies though. |
With respect to changes to dual-stack contents, I agree to @sftim's suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more feedback
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md
Outdated
Show resolved
Hide resolved
|
||
<!-- body --> | ||
|
||
## Installation | ||
|
||
The kubelet has a single default network plugin, and a default network common to the entire cluster. It probes for plugins when it starts up, remembers what it finds, and executes the selected plugin at appropriate times in the pod lifecycle (this is only true for Docker, as CRI manages its own CNI plugins). There are two Kubelet command line parameters to keep in mind when using plugins: | ||
The kubelet has a single default network plugin, and a default network common to the entire cluster.The CRI manages its own CNI plugins. There are two Kubelet command line parameters to keep in mind when using plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This revised paragraph might need technical review. I don't think there is a default network plugin for the kubelet now that dockershim
is gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see discussion in #31667 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be barely OK to merge, provided that we go back and do more fixups.
/lgtm |
LGTM label has been added. Git tree hash: 47595f1fc05bc9081ded0016841e441e582b0de0
|
/lgtm |
LGTM label has been added. Git tree hash: cd4c869865feff49b74988be6463a803aa1aea06
|
|
||
<!-- body --> | ||
|
||
## Installation | ||
|
||
The kubelet has a single default network plugin, and a default network common to the entire cluster. It probes for plugins when it starts up, remembers what it finds, and executes the selected plugin at appropriate times in the pod lifecycle (this is only true for Docker, as CRI manages its own CNI plugins). There are two Kubelet command line parameters to keep in mind when using plugins: | ||
The kubelet has a single default network plugin, and a default network common to the entire cluster.The CRI manages its own CNI plugins. There are two Kubelet command line parameters to keep in mind when using plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kubelet has a single default network plugin, and a default network common to the entire cluster.The CRI manages its own CNI plugins. There are two Kubelet command line parameters to keep in mind when using plugins: | |
The kubelet has a single default network plugin, and a default network common to the entire cluster. The CRI manages its own CNI plugins. There are two Kubelet command line parameters to keep in mind when using plugins: |
nit: missing space, can be fixed in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kubelet has a single default network plugin
Is this true for v1.24 and later?
I'm happy to see this merged, I do hope we also get the nits tidied up. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mk46 would you be willing to open a new PR to further tweak that page based on the feedback in this PR? |
* `--pod-cidr`: The CIDR to use for pod IP addresses, only used in standalone mode. | ||
In cluster mode, this is obtained from the master. For IPv6, the maximum number of IP's allocated is 65536. For example `--pod-cidr=10.180.0.0/24`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `--pod-cidr`: The CIDR to use for pod IP addresses, only used in standalone mode. | |
In cluster mode, this is obtained from the master. For IPv6, the maximum number of IP's allocated is 65536. For example `--pod-cidr=10.180.0.0/24`. | |
* `--pod-cidr`: The CIDR to use for pod IP addresses, only used in standalone mode. | |
In cluster mode, this is obtained from the master. For IPv6, the maximum number of IP's allocated is 65536. For example `--pod-cidr=10.180.0.0/24`. |
This parameter is deprecated see reference: https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/
Maybe we should remove it in a follow-up PR
Removing reference of
kubenet
from docs./kind cleanup
/language en
Fixes #31659