Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving windows resource management to separate page #31850

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

Moving windows resource management topics to a separate page.

Part of #31428

/label refactor
/sig windows

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2022
@netlify
Copy link

netlify bot commented Feb 22, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: f217a54

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6215534d7c66320007033b0c

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 22, 2022
@marosset marosset mentioned this pull request Feb 22, 2022
31 tasks
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about combining this information into https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ ?

Although Kubernetes started out as Linux only, Windows support is now GA and a cluster with only Windows nodes is a supported configuration.

@marosset
Copy link
Contributor Author

How about combining this information into https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ ?

Although Kubernetes started out as Linux only, Windows support is now GA and a cluster with only Windows nodes is a supported configuration.

I don't think clusters with only Windows nodes is a supported configuration.
Most of the control plane components can at least compile on Windows but we do not test or advocate running any of them on Windows nodes (AFAIK)

I will try to merge information in this PR into the existing manage-resources-containers page.

@sftim
Copy link
Contributor

sftim commented Feb 23, 2022

I don't think clusters with only Windows nodes is a supported configuration.

I think it actually is, because you can run the control plane on Linux on, eg, bare metal with only the nodes running Windows. We recommend running the control plane in containers but you don't actually have to.

@marosset
Copy link
Contributor Author

I don't think clusters with only Windows nodes is a supported configuration.

I think it actually is, because you can run the control plane on Linux on, eg, bare metal with only the nodes running Windows. We recommend running the control plane in containers but you don't actually have to.

I think this depends on the definition of supported :)

I'll try to get these updates merged into the existing resource management page today or tomorrow.

@marosset marosset added this to In Review (v1.24) in SIG-Windows Feb 24, 2022
@marosset marosset moved this from In Review (v1.24) to Docs updates (#31428) in SIG-Windows Mar 10, 2022
@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

I see no blocking issues on the PR. Let's move this forward.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c13aefb22f34bffd34112707fc5a76eafd2ed01

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 81aee21 into kubernetes:dev-1.24 Mar 25, 2022
SIG-Windows automation moved this from Docs updates (#31428) to Done (v1.24) Mar 25, 2022
@marosset marosset deleted the move-windows-resource-management-1.24 branch April 5, 2022 19:40
@jihoon-seo jihoon-seo mentioned this pull request Jul 27, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG-Windows
  
Done (v1.24)
Development

Successfully merging this pull request may close these issues.

None yet

5 participants