Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update to Mermaid 8.14.0 #32940

Closed
wants to merge 8 commits into from
Closed

[WIP] Update to Mermaid 8.14.0 #32940

wants to merge 8 commits into from

Conversation

chrismetz09
Copy link
Contributor

Investigating problem with Firefox rendering of mermaid diagrams. Updated to current Mermaid 8.14.0 version to check problem in deploy preview.

Problem and steps so far documented in Issue #31960.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pi-victor after the PR has been reviewed.
You can assign the PR to them by writing /assign @pi-victor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 60bb643
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62586c1259404700072259cb
😎 Deploy Preview https://deploy-preview-32940--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chrismetz09 chrismetz09 mentioned this pull request Apr 14, 2022
Open
@chrismetz09
Copy link
Contributor Author

Mermaid syntax error will be handled by another PR

@chrismetz09 chrismetz09 deleted the t814 branch May 27, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrismetz09 @k8s-ci-robot