Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to Kubernetes support period info #32986

Closed
wants to merge 5 commits into from
Closed

Add links to Kubernetes support period info #32986

wants to merge 5 commits into from

Conversation

samnoon1971
Copy link
Contributor

Hi there! I added the necessary hyperlinks, would you please verify them?
Regards

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 16, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @samnoon1971!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign annajung after the PR has been reviewed.
You can assign the PR to them by writing /assign @annajung in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Apr 16, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 16, 2022
@netlify
Copy link

netlify bot commented Apr 16, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 4955ed2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/626d69e69512c600083933e8
😎 Deploy Preview https://deploy-preview-32986--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 16, 2022
sftim
sftim reviewed Apr 16, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

With a couple of tweaks, this will be good to merge.

content/en/releases/_index.md Outdated Show resolved Hide resolved
content/en/docs/home/supported-doc-versions.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Apr 16, 2022

/retitle Add links to Kubernetes support period info

@k8s-ci-robot k8s-ci-robot changed the title Necessary Hyperlinks Added Add links to Kubernetes support period info Apr 16, 2022
@sftim sftim mentioned this pull request Apr 16, 2022
Closed
sftim
sftim reviewed Apr 16, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnoon1971 could you edit the commit messages here to not mention the issue that you're fixing? Because of issues with forks, we prefer not to do that.

https://linuxize.com/post/change-git-commit-message/ has some good tips on how to make that happen.

sftim
sftim requested changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnoon1971 could you edit the commit messages here to not mention the issue that you're fixing? Because of issues with forks, we prefer not to do that.

https://linuxize.com/post/change-git-commit-message/ has some good tips on how to make that happen.

(I forgot to mark the previous review as Request changes)

samnoon1971 and others added 2 commits April 16, 2022 19:08
@samnoon1971 @sftim
Update content/en/releases/_index.md
f210d5a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@samnoon1971 @sftim
Update content/en/docs/home/supported-doc-versions.md
a994e68 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@samnoon1971
Copy link
Contributor Author

Hi @sftim, Please check the changes as per suggested. Thanks!

@samnoon1971 samnoon1971 reopened this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samnoon1971 @k8s-ci-robot @sftim