Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand manual token secret creation docs #33675

Merged
merged 1 commit into from
May 29, 2022
Merged

Expand manual token secret creation docs #33675

merged 1 commit into from
May 29, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 15, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot requested a review from karlkfi May 15, 2022 03:30
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label May 15, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 15, 2022
@netlify
Copy link

netlify bot commented May 15, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 259da65
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/629293120f9e3900098c28ac
😎 Deploy Preview https://deploy-preview-33675--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

karlkfi
karlkfi reviewed May 15, 2022
View reviewed changes
Copy link

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
@zshihang
Copy link
Contributor

/lgtm
thanks for updating the doc.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83041b32fc0c0c94afb739a5c0c1c4fbfbba551f

@karlkfi
Copy link

karlkfi commented May 23, 2022

None of my comments are blocking.
Looks like it just needs approval.

@liggitt
Copy link
Member Author

liggitt commented May 28, 2022

/cc @shannonxtreme @sftim

relevant to slack thread about these docs at https://kubernetes.slack.com/archives/C01D8R7ACQ2/p1653683287935809

shannonxtreme
shannonxtreme approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@shannonxtreme shannonxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style suggestions but these can always be done later

/lgtm

content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/secret.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2022
@liggitt
Copy link
Member Author

liggitt commented May 28, 2022

comments addressed in https://github.com/kubernetes/website/compare/676752ec80c8fe196549337ea1a17c398f8b02a4..259da65e6aac795c1d90b68006b136094fd129d8

@shannonxtreme
Copy link
Contributor

This looks good IMO, thanks Jordan

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 641e47d0de94bb4ccaf5d84d59c98533f68ebc3e

@tengqm
Copy link
Contributor

tengqm commented May 29, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shannonxtreme, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 978b7ca into kubernetes:main May 29, 2022
@calvin0327 calvin0327 mentioned this pull request Jun 13, 2022
Closed
@liggitt liggitt deleted the token branch April 14, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlkfi karlkfi karlkfi left review comments

@zshihang zshihang Awaiting requested review from zshihang

@sftim sftim Awaiting requested review from sftim

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@zshihang zshihang

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @zshihang @k8s-ci-robot @karlkfi @shannonxtreme @tengqm