Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create windows.md #34006

Merged
merged 35 commits into from
Jun 9, 2022
Merged

Create windows.md #34006

merged 35 commits into from
Jun 9, 2022

Conversation

ihuibin
Copy link
Contributor

@ihuibin ihuibin commented May 28, 2022

Signed-off-by: bin.hui bin.hui@daocloud.io

@ihuibin
Create windows.md
dca3720 
Signed-off-by: bin.hui <bin.hui@daocloud.io>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language labels May 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 28, 2022
@netlify
Copy link

netlify bot commented May 28, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ca1589e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62935a326a3a2b00094e009e
😎 Deploy Preview https://deploy-preview-34006--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sea-n
Sea-n reviewed May 28, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review after machine translation before submit your PR.

Netlify preview: https://deploy-preview-34006--kubernetes-io-main-staging.netlify.app/zh/docs/tasks/debug/debug-cluster/windows

content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated

4. 容器的 vnic 和 HNS endpoints 正在被删除

这个问题可能是当' hostname-override '参数没有传递给 [kube-proxy] (/docs/reference/command-line-tools-reference/kube-proxy/)时引起的。想要解决这个问题，用户需要将主机名传递给 kube-proxy ，如下所示：
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Sea-n Sea-n mentioned this pull request May 28, 2022
Merged
tengqm
tengqm reviewed May 29, 2022
View reviewed changes
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated
content_type: concept
---
<!--
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated
---
title: Windows debugging tips
content_type: concept
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
content/zh/docs/tasks/debug/debug-cluster/windows.md Outdated Show resolved Hide resolved
ihuibin and others added 19 commits May 29, 2022 19:04
@ihuibin @Sea-n
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
cfd2e08 
Co-authored-by: Sean <me@sean.taipei>
@ihuibin @Sea-n
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
4c7a2d0 
Co-authored-by: Sean <me@sean.taipei>
@ihuibin @Sea-n
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
ef6df99 
Co-authored-by: Sean <me@sean.taipei>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
f44bb55 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
11ce4e6 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
98f1323 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
b7c3172 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
fd72433 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
07a1e16 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
fa98e4b 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
e6206fa 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
be5c353 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
0f4ddcd 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
a386d90 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
42f5853 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
208303e 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
6000534 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
9ba2cab 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
fb74645 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
ihuibin and others added 12 commits May 29, 2022 19:14
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
8dfec4d 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
d5217c9 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
eff1001 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
1806cdc 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
49f0563 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
3fabc6f 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
740d1d0 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
8bf284c 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
8319771 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
d4eaa3a 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin @tengqm
Update content/zh/docs/tasks/debug/debug-cluster/windows.md
f0eda0e 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@ihuibin
Update windows.md
ca1589e 
Signed-off-by: bin.hui <bin.hui@daocloud.io>
@tengqm
Copy link
Contributor

tengqm commented May 29, 2022

This is crazy. We have 35 commits for this PR now, and I have got 34 email notifications.
@ihuibin, can you do these commits at your local machine and then git commit --amend followed by a git push -f?

@ihuibin
Copy link
Contributor Author

ihuibin commented May 29, 2022

sorry，sorry

@ydFu
Copy link
Member

ydFu commented May 29, 2022

sorry，sorry

If you have problems with the way you use git commands, you can ask your questions. Otherwise, similar contributions will trouble the zh code view team.

This was referenced May 30, 2022
Closed
Closed
@tengqm
Copy link
Contributor

tengqm commented Jun 2, 2022

@ihuibin Interested in moving this forward (squash your commits)?

@ihuibin
Copy link
Contributor Author

ihuibin commented Jun 5, 2022

I squash 34 commits in github desktop.

@tengqm
Copy link
Contributor

tengqm commented Jun 6, 2022

@ihuibin Please git push -f after you have squashed your commits.

@tengqm
Copy link
Contributor

tengqm commented Jun 9, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 9, 2022
@tengqm
Copy link
Contributor

tengqm commented Jun 9, 2022

I'm kicking this in and leave improvements as future works.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5bcbdab0e0af9bd71d89be07f3bf273302ecb85d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 431e91b into kubernetes:main Jun 9, 2022
@ihuibin
Copy link
Contributor Author

ihuibin commented Jun 9, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@Sea-n Sea-n Sea-n left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@ydFu ydFu Awaiting requested review from ydFu

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ihuibin @tengqm @ydFu @k8s-ci-robot @Sea-n