Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Windows intro and resource management pages #34083

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Updating Windows intro and resource management pages #34083

merged 2 commits into from
Jun 6, 2022

Conversation

marosset
Copy link
Contributor

  • Fixing heading levels for /docs/concepts/windows/intro.md
  • Misc updates to /docs/concepts/windows/intro.ms
  • Updates to /docs/concepts/configuration/windows-resource-management.md
    for accuracy

Signed-off-by: Mark Rossetti marosset@microsoft.com

Part of #31428
Fixes some comments in #33582

@marosset
Updating some Windows docs pages including:
98a31da 
- Fixinig heading levels for /docs/concepts/windows/intro.md
- Misc updates to /docs/concepts/windows/intro.ms
- Updates to /docs/concepts/configuration/windows-resource-management.md
for accuracy

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 31, 2022
@marosset
Copy link
Contributor Author

/assign @jsturtevant
for technical review

/cc @tengqm @sftim

@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm May 31, 2022 22:35
@marosset marosset changed the title Updating some Windows docs pages including: Updating Windows intro and resource management pages May 31, 2022
@marosset
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label May 31, 2022
@netlify
Copy link

netlify bot commented May 31, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit db6814f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6299371477d50f0008806e89
😎 Deploy Preview https://deploy-preview-34083--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tengqm
tengqm reviewed Jun 1, 2022
View reviewed changes
content/en/docs/concepts/configuration/windows-resource-management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/windows-resource-management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/windows-resource-management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/windows-resource-management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/configuration/windows-resource-management.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
divya-mohan0209
divya-mohan0209 reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few grammatical nits

content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
content/en/docs/concepts/windows/intro.md Outdated Show resolved Hide resolved
@marosset marosset added this to Docs updates (#31428) in SIG-Windows Jun 2, 2022
@marosset @tengqm
@sftim @divya-mohan0209
Apply suggestions from code review
db6814f 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
@tengqm
Copy link
Contributor

tengqm commented Jun 3, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 3, 2022
@tengqm
Copy link
Contributor

tengqm commented Jun 3, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@tengqm tengqm mentioned this pull request Jun 3, 2022
Merged
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: caa2e52fa49ebeaeb02cb20635f6dd51f3b9ae93

@k8s-ci-robot k8s-ci-robot merged commit eb88ef7 into kubernetes:main Jun 6, 2022
SIG-Windows automation moved this from Docs updates (#31428) to Done (v1.25) Jun 6, 2022
@windsonsea windsonsea mentioned this pull request Jun 7, 2022
Merged
@marosset marosset mentioned this pull request Jun 7, 2022
Open
31 tasks
@jihoon-seo jihoon-seo mentioned this pull request Jul 11, 2022
Closed
@jihoon-seo jihoon-seo mentioned this pull request Jul 27, 2022
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@sftim sftim sftim left review comments

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG-Windows
  
Done (v1.25)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marosset @tengqm @k8s-ci-robot @jsturtevant @divya-mohan0209 @sftim