Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Drop windows pages that were moved #34201

Merged
merged 1 commit into from
Jun 10, 2022
Merged

[zh] Drop windows pages that were moved #34201

merged 1 commit into from
Jun 10, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 9, 2022

Some windows pages have been relocated and reworked. This PR drops the
Chinese localization of these pages.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 8339794
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62a3130288b3ae0008351457
😎 Deploy Preview https://deploy-preview-34201--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
[zh] Drop windows pages that were moved
8339794 
Some windows pages have been relocated and reworked. This PR drops the
Chinese localization of these pages.
@Sea-n
Copy link
Member

Sea-n commented Jun 10, 2022

Yeah, it's moved in PR #33582 and new pages was translated in umbrella issue #34033.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59aadd64a84ef5f4a1c3aa4d9f44413f1e049d32

@howieyuen
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howieyuen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit e63d62e into kubernetes:main Jun 10, 2022
@tengqm tengqm deleted the drop-win-pages branch June 10, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@chenxuc chenxuc Awaiting requested review from chenxuc

Assignees

@Sea-n Sea-n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tengqm @Sea-n @k8s-ci-robot @howieyuen