Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] updated /concepts/architecture/control-plane-node-communication.md #34911

Closed
wants to merge 1 commit into from

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Jul 10, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign seokho-son after the PR has been reviewed.
You can assign the PR to them by writing /assign @seokho-son in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 10, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 10, 2022
@netlify
Copy link

netlify bot commented Jul 10, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2dc2651
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cad0b39ef75100088028ee
😎 Deploy Preview https://deploy-preview-34911--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo
Copy link
Member

jihoon-seo commented Jul 13, 2022

@windsonsea Thank you for suggesting changes.
But it seems that many other parts of the localized doc are also outdated,
and since @jka236 assigned himself on updating this doc (in #34903),
so IMO it would be great to have @jka236 resync the doc thoroughly in his future PR.

Again, thank you for suggesting changes! 😊

@jka236 님: 작업하실 때, 이 PR의 변경 사항도 빠짐없이 반영되었는지 확인해 주시면 될 것 같습니다. 😊

@windsonsea
Copy link
Member Author

ok, then this PR can be closed.

/close

@k8s-ci-robot
Copy link
Contributor

@windsonsea: Closed this PR.

In response to this:

ok, then this PR can be closed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants