Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update concepts/cluster-administration/networking.md #35051

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c10887
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6308557353db5f0008853478
😎 Deploy Preview https://deploy-preview-35051--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atoato88
Copy link
Contributor

atoato88 commented Aug 8, 2022

FYI:
PR #35754 which might be big change to a original EN page is created just yesterday.
I think it's better to keep an eye on that PR. 🤔

@atoato88
Copy link
Contributor

atoato88 commented Aug 8, 2022

/cc

@t-inu
Copy link
Member Author

t-inu commented Aug 8, 2022

@atoato88 Thank you for the information.
As you said, I'd like to focus on what will be updated.

@nasa9084
Copy link
Member

nasa9084 commented Aug 8, 2022

/assign

@atoato88
Copy link
Contributor

That PR made progress. More bigger changes may be going to come, but it's easy way to update, I think.
Because which will eliminate the list and create link to other page.
In any case, It's needed to focus on that. 😁

@atoato88
Copy link
Contributor

Finally, PR #35754 was merged.
We can go. 😉

@t-inu
Copy link
Member Author

t-inu commented Aug 24, 2022

/retitle [ja] Update concepts/cluster-administration/networking.md

@k8s-ci-robot k8s-ci-robot changed the title [WIP] [ja] Update concepts/cluster-administration/networking.md [ja] Update concepts/cluster-administration/networking.md Aug 24, 2022
@t-inu t-inu marked this pull request as ready for review August 24, 2022 12:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@atoato88
Copy link
Contributor

/lgtm
Thank you for updating!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a649c1e02ae3b2d0e6ecc4cf4fc666d5a454a9d2

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 26, 2022
@t-inu
Copy link
Member Author

t-inu commented Aug 26, 2022

I resolved the conflict.
After rebased, this URL
[ネットワーク設計ドキュメント](https://git.k8s.io/community/contributors/design-proposals/network/networking.md)
changed to
[ネットワーク設計ドキュメント](https://git.k8s.io/design-proposals-archive/network/networking.md)
This change is the same to my updating, so need not to fix anything.

@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b88854881b77cc663464cfd675287f342febed3

@k8s-ci-robot k8s-ci-robot merged commit bed8b24 into kubernetes:main Aug 29, 2022
@t-inu t-inu deleted the issue33000 branch August 30, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] concepts/cluster-administration/networking might be outdated
4 participants