Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate docs/en/tasks/administer-cluster/namespaces into Korean #35302

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Translate docs/en/tasks/administer-cluster/namespaces into Korean #35302

merged 1 commit into from
Jul 27, 2022

Conversation

kyungjin99
Copy link
Contributor

Resolves #35283

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 24, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 24, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kyungjin99 / name: Kyungjin Kim (cc0567e)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 24, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kyungjin99!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jmyung July 24, 2022 03:02
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 24, 2022
@netlify
Copy link

netlify bot commented Jul 24, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 74172b9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62dec3a90206960008a2b5d3
😎 Deploy Preview https://deploy-preview-35302--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 24, 2022
@k8s-ci-robot k8s-ci-robot changed the title [ko] Translate docs/tasks/administer-cluster/namespaces into Korean Translate docs/tasks/administer-cluster/namespaces into Korean Jul 24, 2022
@jihoon-seo
Copy link
Member

@kyungjin99 안녕하세요 기여 감사합니다~~
#35302 (comment) 와 같이
k8s repo들에서는 commit message에 @, # 등을 사용하지 못하도록 되어 있습니다.

image

commit message를 적절히 수정하시고 force-push 하시면 될 것 같은데, 가능하실까요? 😊

@seokho-son
Copy link
Member

Resolves #35283 를 메시지에서 삭제하시면 됩니다. :)

방법은 https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message 를 참고하셔도 좋을 것 같습니다. :)

(예시)

  1. git commit --amend 로 최근 커밋을 변경 (커밋 명칭 변경도 커밋 변경입니다.)
  2. git rebase -i HEAD~n 으로 커밋들을 변경하면서 커밋 메시지 다시 지정

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 25, 2022
@kyungjin99 kyungjin99 changed the base branch from main to dev-1.24-ko.2 July 25, 2022 15:52
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2022
@kyungjin99 kyungjin99 changed the title Translate docs/tasks/administer-cluster/namespaces into Korean Translate docs/en/tasks/administer-cluster/namespaces into Korean Jul 25, 2022
@kyungjin99 kyungjin99 changed the base branch from dev-1.24-ko.2 to main July 25, 2022 16:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2022
@kyungjin99 kyungjin99 changed the base branch from main to dev-1.24-ko.2 July 25, 2022 16:10
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2022
@kyungjin99 kyungjin99 changed the base branch from dev-1.24-ko.2 to main July 25, 2022 16:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2022
@kyungjin99 kyungjin99 changed the base branch from main to dev-1.24-ko.2 July 25, 2022 16:26
@seokho-son
Copy link
Member

/assign @seokho-son

seokho-son
seokho-son reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyungjin99 님~~ 기여 감사합니다!!
신규 문서 한글화에 고생 많으셨습니다.
한글화를 너무 잘 진행해주셨네요. 내공이 있으신 것 같습니다. ㅎㅎ

현재 한글 문서들과 스타일을 맞추는 차원에서, 여러가지 의견을 남겼습니다.
모두 다 반영하실 필요는 없고, 읽어보시고 합당해 보이는 의견을 수용하시면 되겠습니다.
이견이 있으시거나, 궁금한 점은 편하게 코멘트로 남겨주시구요!

content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/cluster-administration/namespaces.md Outdated Show resolved Hide resolved
@kyungjin99 kyungjin99 force-pushed the patch-1 branch 3 times, most recently from 8fe2172 to 8ed982f Compare July 26, 2022 13:13
@kyungjin99
Copy link
Contributor Author

손멘토님 서멘토님 감사합니다!! 😃 코멘트 주신 내용 반영해서 커밋 수정했습니다.
어제까지 빌드는 잘 됐는데 무언가 건드렸는지 갑자기 git submodule update 때문에 fail이 나네요.. 뭐가 문제인지 찾아보겠습니다

@seokho-son
Copy link
Member

@kyungjin99

netlify-bot이 preview 제공을 위해 빌드를 수행하는데,
빌드 오류가 있으면 오류 메시지 확인이 가능합니다. :)
https://app.netlify.com/sites/k8s-dev-ko/deploys/62dfe88abebc580008f417ba

Tip :)

10:15:18 PM: ERROR 2022/07/26 13:15:06 [ko] "docs/concepts/cluster-administration/namespaces.md": "서비스" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
Error: Error building site: logged 1 error(s)
10:15:18 PM: Total in 22055 ms
10:15:18 PM: Makefile:38: recipe for target 'deploy-preview' failed
10:15:18 PM: make: *** [deploy-preview] Error 255

@kyungjin99 kyungjin99 force-pushed the patch-1 branch 2 times, most recently from 6985c89 to 1870b91 Compare July 26, 2022 14:47
@netlify
Copy link

netlify bot commented Jul 26, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 3898312
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62e009e002874f00092004fb
😎 Deploy Preview https://deploy-preview-35302--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyungjin99 kyungjin99 force-pushed the patch-1 branch 2 times, most recently from 516dcc1 to 28b390b Compare July 26, 2022 15:22
@kyungjin99
Copy link
Contributor Author

@seokho-son 멘토님 도움 주셔서 감사합니다 !
알려주신대로 가서 보니 서비스만 text랑 term_id 순서가 반대네요 😅

@seokho-son
Copy link
Member

@kyungjin99

Thank you !
/lgtm

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00c981faa6b1b43ffa9f480ec7ed5afbffdb59cb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit d86f877 into kubernetes:dev-1.24-ko.2 Jul 27, 2022
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@jmyung jmyung Awaiting requested review from jmyung

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ko] Translate docs/tasks/administer-cluster/namespace into Korean
4 participants
@kyungjin99 @k8s-ci-robot @jihoon-seo @seokho-son