Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]sync managing-secret-using-config-file.md #35311

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[zh-cn]sync managing-secret-using-config-file.md #35311

merged 1 commit into from
Jul 28, 2022

Conversation

yanrongshi
Copy link
Contributor

@yanrongshi yanrongshi commented Jul 24, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 24, 2022 10:50
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 24, 2022
@netlify
Copy link

netlify bot commented Jul 24, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 86b4266
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e2715c28afef000822648d
😎 Deploy Preview https://deploy-preview-35311--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yanrongshi yanrongshi force-pushed the zh-cn]sync-managing-secret-using-config-file branch from 7eee2ae to ce0152d Compare July 27, 2022 10:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2022
tengqm
tengqm reviewed Jul 27, 2022
View reviewed changes
content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
@@ -121,7 +123,8 @@ parts of that configuration file during your deployment process.
上述用例的实际场景可能是这样：当你部署应用时，使用 Secret 存储配置文件，
你希望在部署过程中，填入部分内容到该配置文件。

<!-- For example, if your application uses the following configuration file: -->
<!--For example, if your application uses the following configuration file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--For example, if your application uses the following configuration file:
<!--
For example, if your application uses the following configuration file:

content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
输出类似于：

```
secret/mysecret created
```

<!-- ## Check the Secret -->
<!--## Check the Secret-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对标题这类段落，尽量用下面这种方式注释，方便查看文档结构。

Suggested change
<!--## Check the Secret-->
<!--
## Check the Secret
-->

content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
@@ -19,7 +19,7 @@ description: Creating Secret objects using resource configuration file.

<!-- steps -->

<!-- ## Create the Config file -->
<!--## Create the Config file-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除这些空格不如加上换行。下同。

Suggested change
<!--## Create the Config file-->
<!--
## Create the Config file
-->

@yanrongshi yanrongshi force-pushed the zh-cn]sync-managing-secret-using-config-file branch 2 times, most recently from 8de7642 to f07f2ec Compare July 28, 2022 09:37
tengqm
tengqm reviewed Jul 28, 2022
View reviewed changes
content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
Comment on lines 161 to 162
<!--##
Create the Secret object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--##
Create the Secret object
<!--
## Create the Secret object

tengqm
tengqm reviewed Jul 28, 2022
View reviewed changes
content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
其中 `YWRtaW5pc3RyYXRvcg==` 解码成 `administrator`。

<!-- ## Clean Up -->
<!--## Clean Up-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--## Clean Up-->
<!--
## Clean Up
-->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我误以为小标题不用进行格式化，感谢您的提醒，我会在接下来的更新中注意这一点

@yanrongshi yanrongshi force-pushed the zh-cn]sync-managing-secret-using-config-file branch from f07f2ec to e564ebc Compare July 28, 2022 11:13
tengqm
tengqm reviewed Jul 28, 2022
View reviewed changes
content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
@@ -146,24 +158,32 @@ stringData:
password: <password>
```

<!-- ## Create the Secret object -->
<!--#
#Create the Secret object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

？？

可否认真仔细一些？

tengqm
tengqm reviewed Jul 28, 2022
View reviewed changes
content/zh-cn/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated
其中 `YWRtaW5pc3RyYXRvcg==` 解码成 `administrator`。

<!-- ## Clean Up -->
<!--##
Clean Up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

？？

@yanrongshi yanrongshi force-pushed the zh-cn]sync-managing-secret-using-config-file branch from e564ebc to def565b Compare July 28, 2022 11:21
@yanrongshi yanrongshi force-pushed the zh-cn]sync-managing-secret-using-config-file branch from def565b to 86b4266 Compare July 28, 2022 11:22
@yanrongshi yanrongshi requested a review from tengqm July 28, 2022 11:30
@tengqm
Copy link
Contributor

tengqm commented Jul 28, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0fdb0aa359008190028551cff3fe62881c85bf1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 550f3e5 into kubernetes:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanrongshi @tengqm @k8s-ci-robot