-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ko] update outdated korean contents in dev-1.24-ko.2 (M31-M35) #35508
[ko] update outdated korean contents in dev-1.24-ko.2 (M31-M35) #35508
Conversation
Signed-off-by: yuzin9712 <dbwls97@ajou.ac.kr>
✅ Deploy Preview for k8s-dev-ko ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/assign @seokho-son |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 깔끔하게 잘 진행해주셨네요!! :)
원문의 reviewer 관련 라인을 공백 -> 주석
처리하는 것은 최근에 결정되었는데, 바로 반영을 해주셨군요!
다만, 해당 사항은 기존 리뷰어 관련 내용을 그대로 유지하고, 앞에 주석을 추가하는 것으로 이야기된 것으로 알고 있습니다. (아직 가이드 문서가 개선되지 않았네요 ㅎㅎ)
그래서 간단히 리뷰 의견을 드렸어요.
그리고, 한글 전용 이미지 파일이 추가된 것도 좋아보입니다~!
그런데 이 PR의 프리뷰를 통해서 보면
https://deploy-preview-35508--k8s-dev-ko.netlify.app/ko/docs/concepts/services-networking/ingress/#%EC%9D%B8%EA%B7%B8%EB%A0%88%EC%8A%A4%EB%9E%80
이미지에 한글 레이블이 짤리는 것 같아요. 글자 크기 때문인 것 같기도 하고,
mermaid.live 사이트랑 PR상에 추가된 이미지에서는 깔끔해보이는데 말이죠 ㅎㅎ
혹시 살펴봐주실 수 있을까요?
content/ko/docs/concepts/services-networking/network-policies.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/services-networking/service-traffic-policy.md
Outdated
Show resolved
Hide resolved
@yuzin9712 이미지 이외에는 사소한 의견들이고, |
@seokho-son |
/label tide/merge-method-squash |
@yuzin9712 님~~ /lgtm |
LGTM label has been added. Git tree hash: 543c91e0ce381d1408346778705f943bacae5cd6
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seokho-son The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
넵 신규로 이슈 올려보겠습니다! 감사합니다 : ) !! |
Signed-off-by: yuzin9712 dbwls97@ajou.ac.kr
안녕하세요!
M31-M35 관련 문서를 업데이트 했습니다!
감사합니다! : )
Related issue: #34903
#34903 (comment)
/language ko