Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] update outdated korean contents in dev-1.24-ko.2 (M31-M35) #35508

Merged

Conversation

yuzin9712
Copy link
Contributor

Signed-off-by: yuzin9712 dbwls97@ajou.ac.kr

안녕하세요!

M31-M35 관련 문서를 업데이트 했습니다!

감사합니다! : )

Related issue: #34903
#34903 (comment)

  • M31. content/en/docs/concepts/services-networking/ingress-controllers.md | 1(+XS) 0(-)
  • M32. content/en/docs/concepts/services-networking/ingress.md | 4(+XS) 54(-)
  • M33. content/en/docs/concepts/services-networking/network-policies.md | 2(+XS) 2(-)
  • M34. content/en/docs/concepts/services-networking/service-traffic-policy.md | 6(+XS) 0(-)
  • M35. content/en/docs/concepts/services-networking/service.md | 22(+S) 2(-)

/language ko

Signed-off-by: yuzin9712 <dbwls97@ajou.ac.kr>
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 261b199
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62efce6668268b000891a5cc
😎 Deploy Preview https://deploy-preview-35508--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

/assign @seokho-son

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzin9712

전체적으로 깔끔하게 잘 진행해주셨네요!! :)

원문의 reviewer 관련 라인을 공백 -> 주석
처리하는 것은 최근에 결정되었는데, 바로 반영을 해주셨군요!

다만, 해당 사항은 기존 리뷰어 관련 내용을 그대로 유지하고, 앞에 주석을 추가하는 것으로 이야기된 것으로 알고 있습니다. (아직 가이드 문서가 개선되지 않았네요 ㅎㅎ)
그래서 간단히 리뷰 의견을 드렸어요.

그리고, 한글 전용 이미지 파일이 추가된 것도 좋아보입니다~!

그런데 이 PR의 프리뷰를 통해서 보면
https://deploy-preview-35508--k8s-dev-ko.netlify.app/ko/docs/concepts/services-networking/ingress/#%EC%9D%B8%EA%B7%B8%EB%A0%88%EC%8A%A4%EB%9E%80
image

이미지에 한글 레이블이 짤리는 것 같아요. 글자 크기 때문인 것 같기도 하고,
mermaid.live 사이트랑 PR상에 추가된 이미지에서는 깔끔해보이는데 말이죠 ㅎㅎ
혹시 살펴봐주실 수 있을까요?

@seokho-son
Copy link
Member

@yuzin9712
해당 PR은 팀 마일스톤과 관련이 있어서, 처리 우선순위가 높습니다!
이 PR은 매우 중요한 PR이에요~~ 👍

이미지 이외에는 사소한 의견들이고,
혹시 이미지 관련 사항 파악에 어려움을 겪고 계신가요?

@yuzin9712
Copy link
Contributor Author

@seokho-son
이미지 관련 이슈를 재현하지 못하고 있다가, 오늘 윈도우 pc에 chrome 으로 접속하니 확인되네요 ㅠㅠ! 내용 빠르게 확인해보겠습니다!!

@seokho-son
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 7, 2022
@seokho-son
Copy link
Member

@seokho-son 이미지 관련 이슈를 재현하지 못하고 있다가, 오늘 윈도우 pc에 chrome 으로 접속하니 확인되네요 ㅠㅠ! 내용 빠르게 확인해보겠습니다!!

@yuzin9712 님~~
이미지 관련 사항은 차기 브랜치에서 살펴봐주세요~~ :)
(별도로 이슈를 올려주시고 진행하셔도 좋을 것 같습니다.)

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 543c91e0ce381d1408346778705f943bacae5cd6

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2022
@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit e982b65 into kubernetes:dev-1.24-ko.2 Aug 7, 2022
@yuzin9712
Copy link
Contributor Author

@seokho-son

넵 신규로 이슈 올려보겠습니다! 감사합니다 : ) !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants