Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated files in dev-1.24-ko.2 (M76-M79) #35528

Merged

Conversation

bconfiden2
Copy link
Member

M76 ~ M79 까지, tasks/administer-cluster 아래 페이지와 관련된 변경사항들을 반영하였습니다!

Related Issue : #34903

4 files to be modified

  1. M76. content/en/docs/tasks/administer-cluster/certificates.md | 252(+L) 200(-)
  2. M77. content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-certs.md | 2(+XS) 2(-)
  3. M78. content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md | 155(+L) 138(-)
  4. M79. content/en/docs/tasks/administer-cluster/kubeadm/upgrading-windows-nodes.md | 15(+S) 10(-)

/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jmyung July 29, 2022 03:49
@bconfiden2
Copy link
Member Author

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md 의 경우 영문 문서보다 1줄 많은데,
이는 영문 문서에서의 오류( #35524 )를 선반영하였습니다!

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 9d30c45
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62eb9ab21d121400087032f3
😎 Deploy Preview https://deploy-preview-35528--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

@jihoon-seo
다른 PR보다 처리 우선 순위가 높은 PR(outdated 처리) 입니다. :)
빠르게 리뷰 및 가이드하여 머지까지 진행이 필요합니다~~

혹시 리뷰 가능하실까요?

@jihoon-seo
Copy link
Member

@seokho-son 넵~~
/assign

Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bconfiden2 잘 작업해 주셨네요 감사합니다!
몇 가지 의견을 남겼습니다. 확인 부탁드립니다. 😊

@bconfiden2
Copy link
Member Author

@jihoon-seo 리뷰 감사드리며 리뷰해주신 내용 모두 반영하였습니다! 🙇
리뷰마다 댓글을 달면 알림이 너무 많이 갈 것 같아서 resolve 표시만 해놨습니다!
path-to-file.exe 나머지 항목들도 찾아서 변경하였습니다!

@jihoon-seo
Copy link
Member

@bconfiden2 감사합니다!!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: daf7eb055bc887fdefeea579366aecb8e6e654a9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b5fa3e into kubernetes:dev-1.24-ko.2 Aug 6, 2022
@bconfiden2 bconfiden2 deleted the 0729_dev-1.24-ko.2_M76-M79 branch August 12, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants