Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] resync: docs/contribute/suggesting-improvements.md #35690

Closed
wants to merge 1 commit into from

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Aug 4, 2022

Signed-off-by: Hu Shuai hus.fnst@fujitsu.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ysyukr for approval by writing /assign @ysyukr in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 4, 2022
Signed-off-by: Hu Shuai <hus.fnst@fujitsu.com>
@seokho-son
Copy link
Member

Hi @hs0210
Thank you for the contribution.

But, #35548 already resolved the issue.
(In case of Korean localization, we manage outdated contents by checking differences between two Korean development branches)

So, let me close this PR.

/close

@k8s-ci-robot
Copy link
Contributor

@seokho-son: Closed this PR.

In response to this:

Hi @hs0210
Thank you for the contribution.

But, #35548 already resolved the issue.
(In case of Korean localization, we manage outdated contents by checking differences between two Korean development branches)

So, let me close this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 212058b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62eb69d4ddfad50009a9b595
😎 Deploy Preview https://deploy-preview-35690--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hs0210 hs0210 deleted the ko-suggesting-improvements branch August 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants