Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated files in dev-1.24-ko.2 (M42-M43) #35734

Closed
wants to merge 1 commit into from

Conversation

NAMU1105
Copy link
Contributor

@NAMU1105 NAMU1105 commented Aug 5, 2022

M42 ~ M43 까지, workloads/pods 아래 페이지와 관련된 변경사항들을 반영하였습니다.

M42. content/en/docs/concepts/workloads/pods/init-containers.md | 1(+XS) 0(-)
M43. content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md | 9(+XS) 8(-)

/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ianychoi for approval by writing /assign @ianychoi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Aug 5, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 635a80c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ecf566cc78060008570a26
😎 Deploy Preview https://deploy-preview-35734--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

  • 관련된 이슈가 있으면 코멘트나 본문에 남겨주시면 좋습니다. :)
    ref Outdated Korean contents in the dev-1.24-ko.2 #34903
  • PR에서 /language ko 레이블은 파일을 기준으로 자동으로 prow가 설정해주므로 추가하실 필요가 없습니다.

향후 PR생성 시에 참고하시면 되겠습니다. :)

@seokho-son
Copy link
Member

@NAMU1105

감사합니다!! :)
일부 원문과 라인이 명확하게 일치하지 않는 부분이 있긴 한데,
꼭 100% 일치시킬 필요는 없으므로 필요시 다음 기회에 수정하면 될 것 같습니다.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@seokho-son seokho-son changed the base branch from main to dev-1.24-ko.2 August 5, 2022 14:37
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2022
@seokho-son seokho-son changed the base branch from dev-1.24-ko.2 to main August 5, 2022 14:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2022
@seokho-son
Copy link
Member

/cancel lgtm

앗, @NAMU1105 님,
해당 PR은 dev-1.24-ko.2 를 base로 해야 하는데, main을 base로 하고 있나봐요.

image

개발 브랜치부터 dev-1.24-ko.2를 base로 시작하고,
PR의 target 브랜치도 dev-1.24-ko.2로 해주셔야 해요.

PR의 target base 브랜치는 GitHub UI를 써서
dev-1.24-ko.2로 쉽게 변경은 할 수 있는데, 이미 main의 커밋들이 피쳐 브랜치에 포함되어 있어서, dev-1.24-ko.2로 변경하는 순간 아래와 같이 main의 다른 사람들 커밋들이 포함되게 됩니다.

image

아무래도 base를 바꿔서 다시 작업해주셔야 할 것 같아요.. :)
수정하신 내용 자체는 LGTM 입니다!!

@seokho-son
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@NAMU1105
Copy link
Contributor Author

NAMU1105 commented Aug 5, 2022

/cancel lgtm

앗, @NAMU1105 님, 해당 PR은 dev-1.24-ko.2 를 base로 해야 하는데, main을 base로 하고 있나봐요.

image

개발 브랜치부터 dev-1.24-ko.2를 base로 시작하고, PR의 target 브랜치도 dev-1.24-ko.2로 해주셔야 해요.

PR의 target base 브랜치는 GitHub UI를 써서 dev-1.24-ko.2로 쉽게 변경은 할 수 있는데, 이미 main의 커밋들이 피쳐 브랜치에 포함되어 있어서, dev-1.24-ko.2로 변경하는 순간 아래와 같이 main의 다른 사람들 커밋들이 포함되게 됩니다.

image

아무래도 base를 바꿔서 다시 작업해주셔야 할 것 같아요.. :) 수정하신 내용 자체는 LGTM 입니다!!

에고 바로 작업해서 올리겠습니다!
번거롭게 해드려서 죄송하고 기다려주셔서 감사합니다

@NAMU1105 NAMU1105 changed the base branch from main to dev-1.24-ko.2 August 5, 2022 15:18
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2022
@NAMU1105 NAMU1105 changed the base branch from dev-1.24-ko.2 to main August 5, 2022 15:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2022
@seokho-son
Copy link
Member

@NAMU1105
시간되실 때 진행해주시면 됩니다. :)
아직 다른 PR들도 좀 남아 있어요 ㅎㅎ
시행착오를 거치며 익숙해진다고 생각하시면 될 것 같습니다!

@seokho-son
Copy link
Member

PR은 필요하신 경우 close 하고, 새로 오픈하셔도 괜찮습니다. (이 경우 close 이유와 새로 생성된 PR에도 언급을 해주심 좋아요)

@NAMU1105 NAMU1105 closed this Aug 5, 2022
@NAMU1105
Copy link
Contributor Author

NAMU1105 commented Aug 5, 2022

This PR is closed since the base branch setting is wrong.
베이스 브랜치를 잘못 설정한 PR이라 클로즈 합니다.

@NAMU1105
Copy link
Contributor Author

NAMU1105 commented Aug 5, 2022

PR은 필요하신 경우 close 하고, 새로 오픈하셔도 괜찮습니다. (이 경우 close 이유와 새로 생성된 PR에도 언급을 해주심 좋아요)

초보자를 넓은 아량으로 품어주셔서 감사합니다 ㅠㅠ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants