New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing created-by label deprecated since 1.9 #35810
Conversation
|
Welcome @yilmi! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey @yilmi, You have to sign the CLA so that we can review this PR and move forward. After signing the CLA, you may use this command to refresh the status: If you have any problem, please take a look at the CLA tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also recommend breaking it down for each language.
Hi @yilmi In case of Korean contents, Korean localization team is handling outdated Korean contents. (we have a routine to update all Korean contents) So, the changes in English document will be synced to Korean. So, could you let us handle the changes in contents/ko/* ? |
Hi @yilmi Thank you for submitting the PR. Please sign the CLA so we can accept it for review. Also, in general a PR should only target a single language. So this PR needs to be broken up into one pr per language (ko, zh, english) |
1418265
to
e31d646
Compare
Hi everyone, I moved to an individual contribution as the CLA signature for a corporate contributor can take some time. @Sea-n / @bradtopol - CLA for an individual contributor was just signed Those changes would also have to be completed for the Chinese content, not sure how I could flag it for someone to pick it up. Thanks! |
Thanks for signing the CLA agreement and change just en files. For Chinese pages, we have some other contributors working on localization and keep sync with upstream (English) version. No need to worry about it. 😊 |
Oh, my bad |
Hi @Arhell, @bradtopol let me know if there's something I should add. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Two suggestions.
6158af5
to
c36f00e
Compare
Co-authored-by: Tim Bannister <tim@scalefactory.com>
c36f00e
to
bf29b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
LGTM label has been added. Git tree hash: 7ac17fd2b6e1850f4214ffa4f7eea6fd6af3660e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why this change?
This changes removes the
created-by
annotation given that it has been deprecated since 1.9, see Kubernetes PR# 54445.This deprecation was announced in the following release notes: