Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing created-by label deprecated since 1.9 #35810

Merged
merged 2 commits into from Sep 2, 2022

Conversation

yilmi
Copy link
Contributor

@yilmi yilmi commented Aug 9, 2022

Why this change?
This changes removes the created-by annotation given that it has been deprecated since 1.9, see Kubernetes PR# 54445.

This deprecation was announced in the following release notes:

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 9, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yilmi / name: Yassine Ilmi (e31d646)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yilmi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 9, 2022
@netlify
Copy link

netlify bot commented Aug 9, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bf29b18
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6311ff1c930355000a2989e4
😎 Deploy Preview https://deploy-preview-35810--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Aug 9, 2022

Hey @yilmi,

You have to sign the CLA so that we can review this PR and move forward.
Just click on the red NOT COVERED button in the first comment.

After signing the CLA, you may use this command to refresh the status:
/easycla

If you have any problem, please take a look at the CLA tutorial.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also recommend breaking it down for each language.

@yilmi
Copy link
Contributor Author

yilmi commented Aug 10, 2022

@Sea-n I'm trying to get a corporate CLA signed on my end, but may switch back to submitting as an individual contributor.

@Arhell sure, will do, thanks for the feedback

@seokho-son
Copy link
Member

Hi @yilmi
Thank you for the contribution. :)

In case of Korean contents, Korean localization team is handling outdated Korean contents. (we have a routine to update all Korean contents) So, the changes in English document will be synced to Korean. So, could you let us handle the changes in contents/ko/* ?

@bradtopol
Copy link
Contributor

Hi @yilmi Thank you for submitting the PR. Please sign the CLA so we can accept it for review. Also, in general a PR should only target a single language. So this PR needs to be broken up into one pr per language (ko, zh, english)
/assign

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2022
@yilmi
Copy link
Contributor Author

yilmi commented Aug 22, 2022

Hi everyone, I moved to an individual contribution as the CLA signature for a corporate contributor can take some time.

@Sea-n / @bradtopol - CLA for an individual contributor was just signed
@seokho-son - Thanks for the heads-up, I removed the changes to the Korean content 👍

Those changes would also have to be completed for the Chinese content, not sure how I could flag it for someone to pick it up.

Thanks!
Yassine

@yilmi yilmi requested review from Arhell and removed request for seokho-son and rajeshdeshpande02 August 22, 2022 17:36
@Sea-n
Copy link
Member

Sea-n commented Aug 22, 2022

Thanks for signing the CLA agreement and change just en files.
/remove-label zh ko

For Chinese pages, we have some other contributors working on localization and keep sync with upstream (English) version. No need to worry about it. 😊

@Sea-n
Copy link
Member

Sea-n commented Aug 22, 2022

Oh, my bad
/remove-language zh ko

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot removed the language/ko Issues or PRs related to Korean language label Aug 22, 2022
@yilmi
Copy link
Contributor Author

yilmi commented Sep 1, 2022

Hi @Arhell, @bradtopol let me know if there's something I should add. Thanks

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Two suggestions.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 2, 2022
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ac17fd2b6e1850f4214ffa4f7eea6fd6af3660e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 73aaba9 into kubernetes:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants