Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file #35848

Merged
merged 10 commits into from
Aug 30, 2022
Merged

[ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file #35848

merged 10 commits into from
Aug 30, 2022

Conversation

ziyi-xie
Copy link
Contributor

There are several updates in the original English text and therefore this page is outdated.
This PR updated Japanese translation for the content/ja/docs/concepts/workloads/pods/_index.md file.

Fixes #35828

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2022
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 10, 2022
@netlify
Copy link

netlify bot commented Aug 10, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7154a0c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/630b2c6b58e4ff00072910b8
😎 Deploy Preview https://deploy-preview-35848--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@t-inu
Copy link
Member

t-inu commented Aug 16, 2022

The original page has "Pod update and replacement" section between "Pod templates" and "Resource sharing and communication".
It looks like this section should be added to the Japanese page as well.

ref: #25756

@ziyi-xie
Copy link
Contributor Author

The original page has "Pod update and replacement" section between "Pod templates" and "Resource sharing and communication". It looks like this section should be added to the Japanese page as well.

ref: #25756

Thank you for your kind instruction! I will go check it right away.

@ziyi-xie
Copy link
Contributor Author

/retitle [WIP][ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file

@k8s-ci-robot k8s-ci-robot changed the title [ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file [WIP][ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file Aug 22, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2022
@ziyi-xie
Copy link
Contributor Author

/retitle [ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file

@k8s-ci-robot k8s-ci-robot changed the title [WIP][ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file [ja] Updated content/ja/docs/concepts/workloads/pods/_index.md file Aug 25, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022
@nasa9084
Copy link
Member

/assign
/approve
but I'm not sure we should use {{< skew currentVersion >}} in Japanese page (because actually sometimes Japanese pages are not well-maintained... sadly though)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Aug 26, 2022

/assign /approve but I'm not sure we should use {{< skew currentVersion >}} in Japanese page (because actually sometimes Japanese pages are not well-maintained... sadly though)
@nasa9084 Thank you for your approval!
And regarding {{< skew currentVersion >}}, could I ask that what would happen if I still use this piece of code and didn't maintain these pages in time? I thought it will change automatically when there's new kubernetes version come out. Thank you so much!

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Aug 26, 2022

/cc @t-inu @atoato88
Hi! I've updated Japanese translation for the content/ja/docs/concepts/workloads/pods/_index.md file, would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

@nasa9084
Copy link
Member

And regarding {{< skew currentVersion >}}, could I ask that what would happen if I still use this piece of code and didn't maintain these pages in time? I thought it will change automatically when there's new kubernetes version come out. Thank you so much!

Yes, as you said, it will change automatically when there's a new kubernetes version, even the document is not updated.
so, my concern is, if .spec.os.name field affects scheduling with a new kubernetes version and this page is not updated, the page will say "the field won't affect scheduling with THE NEW VERSION"....
anyway, I can go as it is for now

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and left comments.

content/ja/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Aug 28, 2022

And regarding {{< skew currentVersion >}}, could I ask that what would happen if I still use this piece of code and didn't maintain these pages in time? I thought it will change automatically when there's new kubernetes version come out. Thank you so much!

Yes, as you said, it will change automatically when there's a new kubernetes version, even the document is not updated. so, my concern is, if .spec.os.name field affects scheduling with a new kubernetes version and this page is not updated, the page will say "the field won't affect scheduling with THE NEW VERSION".... anyway, I can go as it is for now

@nasa9084 Thank you so much for your detailed explanation! I'll keep that in mind and check the updates frequently.

ziyi-xie and others added 5 commits August 28, 2022 17:46
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@atoato88
Copy link
Contributor

It's LGTM.
Should I add ltgm label or wait for adding lgtm tag by other reviewers?

@atoato88
Copy link
Contributor

BTW, I agree with the topic about {{< skew currentVersion >}} spoken here.
And an original English contents have also {{< skew currentVersion >}}, so it's a same situation both of EN and JP(and maybe also same with other language).

@nasa9084
Copy link
Member

And an original English contents have also {{< skew currentVersion >}}, so it's a same situation both of EN and JP(and maybe also same with other language).

I guess this issue can be an issue for other languages but maybe not for English because English contents should be well-maintained than translation...

Should I add ltgm label or wait for adding lgtm tag by other reviewers?

It seems that you are a member of Kubernetes org so you can use /lgtm if you want (https://kubernetes.io/docs/contribute/participate/roles-and-responsibilities/#members) or of course you can just say LGTM and wait for other reviewer.

@t-inu
Copy link
Member

t-inu commented Aug 30, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 30, 2022
@t-inu
Copy link
Member

t-inu commented Aug 30, 2022

Looks good!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2caac761528c3df4b24356efa73b7327245b068

@atoato88
Copy link
Contributor

LGTM too 😄

@k8s-ci-robot k8s-ci-robot merged commit 721ec5f into kubernetes:main Aug 30, 2022
@ziyi-xie ziyi-xie deleted the update-pod branch August 31, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] content/ja/docs/concepts/workloads/pods/_index.md is outdated
5 participants