Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release announcement blog article for Kubernetes v1.25 #35981

Merged
merged 14 commits into from
Aug 23, 2022
Merged

Add release announcement blog article for Kubernetes v1.25 #35981

merged 14 commits into from
Aug 23, 2022

Conversation

katcosgrove
Copy link
Contributor

Adding the release blog for v1.25. A couple of things remain to be collected.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 15, 2022
@katcosgrove
Copy link
Contributor Author

/assign @cici37 @kcmartin @csantanapr

@sftim
Copy link
Contributor

sftim commented Aug 15, 2022 •
edited
Loading

A couple of things remain to be collected.

/retitle [WIP] Add release announcement blog article for Kubernetes v1.25

@k8s-ci-robot k8s-ci-robot changed the title Kubernetes v1.25 release blog [WIP] Add release announcement blog article for Kubernetes v1.25 Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2022
sftim
sftim reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informal review:

  • I / we prefer sentence case for headings
  • various bits of informal feedback

We could fix the TODOs and ship this; we don't have to make the fixes I'm suggesting (they are polish).

content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md Outdated Show resolved Hide resolved
katcosgrove and others added 6 commits August 16, 2022 08:31
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
95da9c0 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
3fb17ad 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
3231042 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
c89df90 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
347e92a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
112ddfa 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@netlify
Copy link

netlify bot commented Aug 16, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 95da9c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62fbb866452c570008ffd805
😎 Deploy Preview https://deploy-preview-35981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a3ea4d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6303f03b4c35260009fa42b6
😎 Deploy Preview https://deploy-preview-35981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim sftim mentioned this pull request Aug 18, 2022
Closed
@katcosgrove
Copy link
Contributor Author

@sftim All requested edits have been made, and TODO items completed.

@dims
Copy link
Member

dims commented Aug 19, 2022

/approve

@katcosgrove
Copy link
Contributor Author

/assign @kcmartin

divya-mohan0209
divya-mohan0209 reviewed Aug 20, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM modulo the one suggestion by @sftim

@cici37
Copy link
Contributor

cici37 commented Aug 22, 2022

The context looks good to me. Thank you for the work!

@sftim
Copy link
Contributor

sftim commented Aug 22, 2022

If this is ready for review, I suggest retitling it to remove the “[WIP]”.

/hold
We only want to publish this once the release has happened.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2022
@katcosgrove @sftim
Update content/en/blog/_posts/2022-08-23-kubernetes-1.25-blog.md
587c31d 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@katcosgrove
Copy link
Contributor Author

/retitle Add release announcement blog article for Kubernetes v1.25

@katcosgrove katcosgrove changed the title [WIP] Add release announcement blog article for Kubernetes v1.25 Add release announcement blog article for Kubernetes v1.25 Aug 22, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2022
@sftim
Copy link
Contributor

sftim commented Aug 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffed6371e673b5da56d755145c3b32d5dcfb5736

@kcmartin
Copy link
Contributor

kcmartin commented Aug 23, 2022 •
edited
Loading

/hold cancel

1 similar comment
@kcmartin
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@kcmartin kcmartin merged commit 7de2081 into kubernetes:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox left review comments

@liggitt liggitt liggitt left review comments

@xing-yang xing-yang xing-yang left review comments

@cici37 cici37 cici37 left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@csantanapr csantanapr

@cici37 cici37

@kcmartin kcmartin

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet