Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download.md #36270

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Update download.md #36270

merged 5 commits into from
Aug 25, 2022

Conversation

rohitg00
Copy link
Contributor

Hello,

After the launch of Kubernetes v1.25 release, I noticed there is a default change in the pull release of container images. Hence, This needs to be visible on the Kubernetes release website page. This works for all images, not just v1.25.

  • this needs to fix as it will help automate further for new projects.
  • screenshot attached.

Screenshot 2022-08-25 at 2 01 21 PM

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 25, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rohitg00 / name: Rohit Ghumare (aaceeb6)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rohitg00!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 25, 2022
@netlify
Copy link

netlify bot commented Aug 25, 2022 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9bd22c7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6307473ff16de7000872d8be
😎 Deploy Preview https://deploy-preview-36270--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 25, 2022
sftim
sftim reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense given https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.25.md#moved-container-registry-service-from-k8sgcrio-to-registryk8sio

However, there is a mistake in the PR (see inline feedback)

content/en/releases/download.md Outdated Show resolved Hide resolved
rohitg00 and others added 2 commits August 25, 2022 14:48
@rohitg00 @sftim
Update content/en/releases/download.md
79d45d9 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@rohitg00 @sftim
Update content/en/releases/download.md
33b2390 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
sftim
sftim reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Aug 25, 2022
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2a2e77cc7da3957e14ac06c0c7cfe9841a41751

@tengqm
Copy link
Contributor

tengqm commented Aug 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit ff8b2b4 into kubernetes:main Aug 25, 2022
sftim
sftim reviewed Aug 25, 2022
View reviewed changes
content/en/blog/_posts/2020-05-27-An-Introduction-to-the-K8s-Infrastructure-Working-Group.md
- The container registry [k8s.gcr.io](https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io) is also fully community-owned and available for all Kubernetes subprojects to use.
- The container registry [registry.k8s.io](https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-\(registry.k8s.io\)) is also fully community-owned and available for all Kubernetes subprojects to use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Should we have edited this blog article? We usually don't, and we're changing the meaning of someone else's article.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky! It's needed at the moment, If we're maintaining default changes.

Copy link
Member

@reylejano reylejano Aug 25, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to reverting the change to the blog and add a note that the container registry is updated to registry.k8s.io

Copy link
Member

@reylejano reylejano Aug 25, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up PR #36284

@reylejano reylejano mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@reylejano reylejano reylejano left review comments

@onlydole onlydole Awaiting requested review from onlydole

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rohitg00 @k8s-ci-robot @reylejano @tengqm @sftim