New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to userspace proxy #38284
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this change should land after we merge in main
The proxy modes are now documented in https://kubernetes.io/docs/reference/networking/virtual-ips/
Avoid touching autogenerated files such as /hold |
You might also like to work on #38244 @danwinship |
7af7041
to
1846eae
Compare
ah, well, I just copied the text from |
I'm not sure what that means relative to what ends up in the official 1.26 documentation, but note that as of right now, |
I'm worried that our choices might come down to:
It'd be nice to find a third option here. |
#38242 is about to land. If you rebase on upstream's dev-1.26 then we should be able to get this in the release. If not, it's not a huge problem because this repo is continously deployed: update the PR to target main, go through code review, and we can get an update out, pronto. |
kube-proxy supports two proxy modes—iptables and IPVS—which | ||
operate slightly differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a kernelspace
mode - see #38244
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR necessarily conflicts with that one (that PR modifies the text immediately before the ### User space proxy mode
heading which this PR removes), so one of us will have to rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What matters most to me is not provoking a merge conflict for dev-1.26 going into main.
I can add the kernelspace one into the dev-1.26
docs and then, after the v1.26, propose a backport.
1846eae
to
37ee1e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 9e78ef58b6beb7118706b18601dad274c37592a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krol3, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manually triggering a merge by GitHub as repository is frozen for 1.26 release. |
While belatedly looking at #36675 I saw that we still talk about the userspace proxy in a bunch of places, but it's gone in 1.26 (kubernetes/kubernetes#112133).
I didn't remove
static/images/docs/services-userspace-overview.{svg,png}
because it's referenced by the translations ofservice.md
too./cc @sftim