Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentioned required cosign version for the --certificate flag #39080

Merged
merged 1 commit into from Feb 8, 2023
Merged

Mentioned required cosign version for the --certificate flag #39080

merged 1 commit into from Feb 8, 2023

Conversation

saschagrunert
Copy link
Member

Fixes #38473

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 09d013b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63d0e0613c73cf000872f702
😎 Deploy Preview https://deploy-preview-39080--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This'll want tech review from someone who can confirm that's how cosign works.

content/en/docs/tasks/administer-cluster/verify-signed-artifacts.md Outdated
Comment on lines 50 to 53
{{< note >}}
cosign v1.9.0 is required to be able to use the `--certificate` flag.
Please use `--cert` for older versions of cosign.
{{< /note >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest making the following paragraph not be a note. The page will read better as a result, and people will still see the link to learn more.

Extra credit: copy that link to a “what's next” section at the foot of the page (see other tasks pages for an example)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the note. Regarding the "What's next" section: What should we expect content wise there? Wouldn't we duplicate information if mentioning again that cosign has to be up to date? We could link to the cosign changelog and show how it can be updated, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docs, it's OK to duplicate information from earlier into the page into the What's Next section.

Something like this:

## {{% heading "whatsnext" %}}

Read
[Keyless Signatures](https://github.com/sigstore/cosign/blob/main/KEYLESS.md#keyless-signatures)
to learn more about Sigstore keyless signing.

@saschagrunert
Mentioned required cosign version for the --certificate flag
09d013b 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@tengqm
Copy link
Contributor

tengqm commented Jan 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@sftim
Copy link
Contributor

sftim commented Jan 27, 2023

@saschagrunert could you recommend a tech reviewer for this? I'm happy to LGTM it for SIG Docs.

@saschagrunert
Copy link
Member Author

@puerco @cpanato PTAL from a technical standpoint.

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19d0c17eafa27dbd5a5bfdd13e3ad37a5c855d3f

@k8s-ci-robot k8s-ci-robot merged commit 4e4c238 into kubernetes:main Feb 8, 2023
@saschagrunert saschagrunert deleted the cosign-version branch February 8, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@sftim sftim sftim left review comments

@reylejano reylejano reylejano left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong cosign command in “Verify Signed Kubernetes Artifacts” task
6 participants
@saschagrunert @tengqm @k8s-ci-robot @sftim @reylejano @cpanato