Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ru] Localization of /concepts/scheduling-eviction/assign-pod-node.md #39162

Closed
wants to merge 2 commits into from
Closed

[ru] Localization of /concepts/scheduling-eviction/assign-pod-node.md #39162

wants to merge 2 commits into from

Conversation

kirkonru
Copy link
Contributor

Add RU localization for assign-pod-node.md.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/ru Issues or PRs related to Russian language labels Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 30, 2023
@kirkonru kirkonru mentioned this pull request Jan 30, 2023
Open
shurup
shurup requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great effort is made here. However, it's not fully translated yet. I reviewed the ready part of this document.

content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
@kirkonru kirkonru marked this pull request as ready for review April 27, 2023 17:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

@kirkonru: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kirkonru kirkonru force-pushed the ru_docs_assign-pod-node branch 3 times, most recently from f97d92e to df1b9d0 Compare April 28, 2023 08:22
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2023
@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 354d577
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6471f0769430a700080d7508
😎 Deploy Preview https://deploy-preview-39162--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

shurup
shurup requested changes May 18, 2023
View reviewed changes
Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kirkonru! Here are a few tiny corrections for me.

More importantly, I think the content/ru/docs/reference/issues-security/* files were included in this PR by some mistake? They are not translated and don't seem to be relevant to the main article.

content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated Show resolved Hide resolved
Tariqs and others added 2 commits May 27, 2023 14:49
@Tariqs
Remove annotation from pod
6f3462a
@kirkonru @shurup
Create assign-pod-node.md
354d577 
Apply suggestions from code review

Co-authored-by: Dmitry Shurupov <dmitry.shurupov@palark.com>

Update assign-pod-node.md

Copy /docs/reference/issues-security/* from EN

Update content/ru/docs/concepts/scheduling-eviction/assign-pod-node.md

Add examples/pods/*.yaml files

Translate _index.md

Translate issues.md

Update issues.md

Translate official-cve-feed.md

Translate official-cve-feed.md

Translate security.md

Update _index.md

Update issues.md

Apply suggestions from code review

Co-authored-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign annajung, shurup for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divya-mohan0209
Copy link
Contributor

Hello @kirkonru , please do not make changes to multiple localization files over the same PR since the process for each localization differs.

@tengqm
Copy link
Contributor

tengqm commented Oct 7, 2023

/close
A long time has passed.
Feel free to reopen this PR to move it forward.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
A long time has passed.
Feel free to reopen this PR to move it forward.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kirkonru kirkonru mentioned this pull request Feb 13, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurup shurup shurup requested changes

@tengqm tengqm Awaiting requested review from tengqm

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ru Issues or PRs related to Russian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kirkonru @k8s-ci-robot @divya-mohan0209 @tengqm @shurup @Tariqs