Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated files in dev-1.26-ko.1 (M67) #39219

Merged
merged 1 commit into from Feb 24, 2023
Merged

[ko] Update outdated files in dev-1.26-ko.1 (M67) #39219

merged 1 commit into from Feb 24, 2023

Conversation

jihoon-seo
Copy link
Member

Related issue: #38458

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 2, 2023
@netlify
Copy link

netlify bot commented Feb 2, 2023 •
edited

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 5c6199c
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/63f8663ee3558300087392a1
😎 Deploy Preview https://deploy-preview-39219--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

/assign @seokho-son

seokho-son
seokho-son reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 감사합니다! 많은 수정 사항 처리에 고생 많으셨습니다.
사소한 의견들이 있어서 코멘트 남겼습니다.
amend 해주시면 될 것 같습니다.

/lgtm

content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a03e990412faeac5b909260520d365b19e710a27

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2023
@jihoon-seo
Copy link
Member Author

@seokho-son 리뷰 감사합니다. 모두 반영했습니다. 😊

@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a47b247d485c0000f000869c49ba3ea85adc59fe

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7d89ba1 into kubernetes:dev-1.26-ko.1 Feb 24, 2023
@jihoon-seo jihoon-seo mentioned this pull request May 2, 2023
Closed
@jihoon-seo jihoon-seo deleted the 221216_ko_Update_outdated_M67 branch September 20, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhwa pjhwa Awaiting requested review from pjhwa

@yoonian yoonian Awaiting requested review from yoonian

@seokho-son seokho-son Awaiting requested review from seokho-son

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jihoon-seo @seokho-son @k8s-ci-robot