Add warning that liveness probe must be configured carefully #39930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/docs
tengqm
reviewed
Mar 12, 2023
content/en/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes.md
Outdated
Show resolved
Hide resolved
tengqm
reviewed
Mar 13, 2023
content/en/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
size/S
KanishkaVerma054
requested review from
tengqm and
binboum
and removed request for
onlydole,
reylejano,
tengqm and
binboum
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
do-not-merge/hold
binboum
approved these changes
Mar 13, 2023
tengqm
reviewed
Mar 14, 2023
Comment on lines
32
to
34
| A common pattern for liveness probes is to use the same low-cost HTTP endpoint | ||
| as for readiness probes, but with a higher `failureThreshold`. This ensures that the pod | ||
| is observed as not-ready for some period of time before it is hard killed. |
There was a problem hiding this comment.
This should not be part of the caution?
There was a problem hiding this comment.
@tengqm Should I put this into 'note' section?
There was a problem hiding this comment.
My feeling is that this can be in plain text. It is a hint, not something users must follow or must be alerted for.
There was a problem hiding this comment.
Alright then I will modify the changes
KanishkaVerma054
force-pushed
the
Liveness-Probes-edit
branch
from
45ffe06
to
994fa2c
Compare
|
/hold cancel |
k8s-ci-robot
removed
do-not-merge/hold
|
Hello @tengqm I've modified the changes as you've asked...may you please review my changes. |
|
@KanishkaVerma054 thanks for the PR, it reads very well. I don't have anything to add as there are already great comments. |
KanishkaVerma054
requested review from
binboum and
tengqm
and removed request for
tengqm and
binboum
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 73a65575e0be91bed70f9a4aeeab2bdb3e22ffed
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: binboum, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kemkemG0
pushed a commit
to kemkemG0/website
that referenced
this pull request
Apr 4, 2023
…tes#39930) * a warning on liveness probes about cascading failures, added * A warning that liveness probe must be configured carefully. * better words are added * wrapping of the log lines * warning is modified that liveness probe must be configured carefully
DonatoHorn
pushed a commit
to DonatoHorn/website
that referenced
this pull request
Jun 25, 2023
…tes#39930) * a warning on liveness probes about cascading failures, added * A warning that liveness probe must be configured carefully. * better words are added * wrapping of the log lines * warning is modified that liveness probe must be configured carefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of the Commit
Better words are used.
Which issue(s) this PR fixes
Part of #16607
Description
'killing' is replaced with 'restart' and 'pod' is replaced by 'container'.