Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix column order for feature-gates table #40772

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix: Fix column order for feature-gates table #40772

merged 1 commit into from
Apr 20, 2023

Conversation

sergeyshevch
Copy link
Member

This PR addresses issue #40759

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 19, 2023
@sergeyshevch sergeyshevch changed the title fix: Fix column order for feature-gates table draft: fix: Fix column order for feature-gates table Apr 19, 2023
@sergeyshevch
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@sergeyshevch sergeyshevch force-pushed the fix/fix-column-orders-for-feature-gates branch from d6234da to 3dd4b95 Compare April 19, 2023 10:23
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2023
@sergeyshevch
Copy link
Member Author

/unhold Ready for review

@netlify
Copy link

netlify bot commented Apr 19, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d6234da
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/643fc0b242daf10008a0acc1
😎 Deploy Preview https://deploy-preview-40772--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3dd4b95
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/643fc13dea8b4d0008d84a7e
😎 Deploy Preview https://deploy-preview-40772--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sergeyshevch sergeyshevch changed the title draft: fix: Fix column order for feature-gates table fix: Fix column order for feature-gates table Apr 19, 2023
T-Lakshmi
T-Lakshmi reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@T-Lakshmi T-Lakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

Deploy preview: https://deploy-preview-40772--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

@T-Lakshmi
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 20, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3d4f62ad8d0de67fc1aa52d528bce5e003233a97

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3d38acd into kubernetes:main Apr 20, 2023
@sergeyshevch sergeyshevch mentioned this pull request Apr 1, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Lakshmi T-Lakshmi T-Lakshmi left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sergeyshevch @T-Lakshmi @tengqm @k8s-ci-robot