add more clarification regarding priorityClassName use with DaemonSet #40851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/docs
tzneal
force-pushed
the
add-daemonset-priority-class-information
branch
from
66a0070
to
00ed931
Compare
k8s-ci-robot
removed
the
needs-rebase
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Apr 27, 2023
tzneal
force-pushed
the
add-daemonset-priority-class-information
branch
from
00ed931
to
d41a3a0
Compare
sftim
reviewed
May 2, 2023
| @@ -35,6 +35,10 @@ spec: | |||
| volumeMounts: | |||
| - name: varlog | |||
| mountPath: /var/log | |||
| # system-node-critical is the highest priority class and can be used to ensure that | |||
| # a critical daemonset's pod will evict an existing pod if that is required to allow | |||
There was a problem hiding this comment.
Suggested change
| # a critical daemonset's pod will evict an existing pod if that is required to allow | |
| # a node-critical pod will preempt an existing Pod if that is required to allow |
There was a problem hiding this comment.
I reworked the language a bit, I didn't like the comment being about system-node-critical, with the commented out example being system-cluster-critical. I made it a bit more generic and just used system-cluster-critical in the example. WDYT?
There was a problem hiding this comment.
On reflection, even that's higher that I'm really happy with.
tzneal
force-pushed
the
add-daemonset-priority-class-information
branch
from
d41a3a0
to
ba424af
Compare
sftim
reviewed
May 22, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c1227b2aa4899271ee21a030c81fd42d3ad5c77d
|
reylejano
reviewed
Jul 1, 2023
tzneal
force-pushed
the
add-daemonset-priority-class-information
branch
from
ba424af
to
0ee42c9
Compare
k8s-ci-robot
removed
the
lgtm
sftim
reviewed
Aug 28, 2023
sftim
reviewed
Aug 28, 2023
|
LGTM, despite #40851 (comment) |
tzneal
force-pushed
the
add-daemonset-priority-class-information
branch
from
0ee42c9
to
b900d2c
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7de311a4032482764f2105a62e416cd958b675e9
|
k8s-ci-robot
removed
the
lgtm
tengqm
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: eea3a0c67b335f57e432724688b6588059949289
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using a priority class name can result in DaemonsetPods remaining pending. This can occur with cluster-autoscaler where the new DS pod is created, but can't evict existing
scheduled pods due to not having a high priority class. The DS pod then remains pending
indefinitely unless existing pods on the node happen to terminate to make room.