Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link from Device Plugins page to KEP #41145

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Remove link from Device Plugins page to KEP #41145

merged 2 commits into from
Sep 6, 2023

Conversation

omBratteng
Copy link
Contributor

Update the link to the proposal on the Device Plugins page. Previously pointed to archived repository, now points to enhancements repo and the specific KEP

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2023
@netlify
Copy link

netlify bot commented May 15, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 290a3fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64dc26f410c4c300083f4b18
😎 Deploy Preview https://deploy-preview-41145--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed May 15, 2023
View reviewed changes
content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated
@@ -10,7 +10,7 @@ weight: 20
<!-- overview -->
{{< feature-state for_k8s_version="v1.26" state="stable" >}}

Kubernetes provides a [device plugin framework](https://git.k8s.io/design-proposals-archive/resource-management/device-plugin.md)
Kubernetes provides a [device plugin framework](https://git.k8s.io/enhancements/keps/sig-node/3573-device-plugin/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't link to https://git.k8s.io/enhancements/keps/sig-node/3573-device-plugin/README.md with this link text, as that page doesn't mention the word framework anywhere. This page itself is about device plugins.

I would omit the link here. We can link to https://kep.k8s.io/3573 in the What's next section at the foot of the page, if we want to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah, makes sense.
Not sure what text would suit the link in the What's next section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing the hyperlink?

@bradtopol
Copy link
Contributor

Assigning @sftim since he is already engaged on this.
/assign @sftim

@sftim
Copy link
Contributor

sftim commented Jul 23, 2023

/retitle point Device Plugins page to KEP

@k8s-ci-robot k8s-ci-robot changed the title docs: point Device Plugins page to KEP point Device Plugins page to KEP Jul 23, 2023
@sftim
Copy link
Contributor

sftim commented Jul 23, 2023

/retitle Remove link from Device Plugins page to KEP

@omBratteng please rebase this against main (see https://lwkd.info/2023/20230606#developer-news for context). If you're not sure how to, please reply here to say so and we'll try to help.

@k8s-ci-robot k8s-ci-robot changed the title point Device Plugins page to KEP Remove link from Device Plugins page to KEP Jul 23, 2023
@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

If you're willing to rebase rather than merge in main, we'd prefer that.

@omBratteng
Copy link
Contributor Author

I did a rebase after I saw that I first had merged main

@omBratteng omBratteng force-pushed the patch-1 branch 3 times, most recently from c2bc277 to b3ef78a Compare July 24, 2023 10:53
@omBratteng
Copy link
Contributor Author

Just rebased to get the last commit on main as well

sftim
sftim reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cbcb3ffa96fab2303a7eb6b9b7157837abd9f60b

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit c07275b into kubernetes:main Sep 6, 2023
7 checks passed
@omBratteng omBratteng deleted the patch-1 branch September 8, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omBratteng @bradtopol @sftim @k8s-ci-robot @reylejano