Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate RetroactiveDefaultStorageClass feature to GA in 1.28 #41206

Merged
merged 1 commit into from Jul 25, 2023
Merged

graduate RetroactiveDefaultStorageClass feature to GA in 1.28 #41206

merged 1 commit into from Jul 25, 2023

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented May 18, 2023 •
edited

Graduate RetroactiveDefaultStorageClass featrue to GA in 1.28.

KEP: kubernetes/enhancements#3333
KEP 1.28: kubernetes/enhancements#4021
k/k: kubernetes/kubernetes#118102

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 18, 2023 11:42
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label May 18, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2023
@RomanBednar RomanBednar mentioned this pull request May 18, 2023
Merged
@netlify
Copy link

netlify bot commented May 18, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f904578
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64661879c1b14100082e8a46
😎 Deploy Preview https://deploy-preview-41206--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@RomanBednar RomanBednar changed the base branch from main to dev-1.28 May 18, 2023 12:22
@sftim
Copy link
Contributor

sftim commented May 19, 2023

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 19, 2023
@Shubham82
Copy link
Contributor

This PR will merge once k8s/k8s #118102 will merge, till that put this PR on hold.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2023
@carlory
Copy link
Member

carlory commented May 24, 2023

@RomanBednar please update this doc

https://github.com/kubernetes/website/blob/dev-1.28/content/en/docs/reference/command-line-tools-reference/feature-gates.md#feature-gates-for-graduated-or-deprecated-features

@RomanBednar
Copy link
Contributor Author

@carlory Done.

@carlory
Copy link
Member

carlory commented May 24, 2023

please squash your commits into one

@jsafrane jsafrane mentioned this pull request Jun 5, 2023
Open
12 tasks
@carlory
Copy link
Member

carlory commented Jun 28, 2023

/hold cancel

@tengqm It' ready for review.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@Shubham82
Copy link
Contributor

changes look good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8bc0ed7bf8b09db195711d6ae744fc8e6b62461b

@carlory
Copy link
Member

carlory commented Jun 28, 2023

/assign @reylejano

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@Shubham82
Copy link
Contributor

Thanks, @RomanBednar
changes look good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 297df8eb29e2e3cca323e3b1dd680502efb44b67

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 633e195842cef7e2d5931fb7e7d913dabbda93e1

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@sftim
Copy link
Contributor

sftim commented Jul 11, 2023

/hold

Needs tech review from SIG Storage (should be trivial to get)
/approve

Fine to unhold this once tech reviewed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@carlory
Copy link
Member

carlory commented Jul 12, 2023

/assign @msau42

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c475ceb73f3293df30273c74920961522c72c10

@xing-yang
Copy link
Contributor

/hold cancel

Review is done from sig-storage.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 441889f into kubernetes:dev-1.28 Jul 25, 2023
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 25, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41206 from RomanBednar/retro-sc-assignm…
e9fafa6 
…ent-ga

graduate RetroactiveDefaultStorageClass feature to GA in 1.28
@RomanBednar RomanBednar mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@msau42 msau42 Awaiting requested review from msau42

@onlydole onlydole Awaiting requested review from onlydole

@reylejano reylejano Awaiting requested review from reylejano

@Shubham82 Shubham82 Awaiting requested review from Shubham82

Assignees

@xing-yang xing-yang

@msau42 msau42

@Shubham82 Shubham82

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@RomanBednar @sftim @Shubham82 @carlory @k8s-ci-robot @xing-yang @tengqm @reylejano @msau42